Skip to content

Commit

Permalink
Load timeline.js properly for Firefox (#636)
Browse files Browse the repository at this point in the history
Load JS properly without async and only once. This hopefully works on Firefox and Safari in production. Works locally, and there's no reason it should be different for production now since I took out the `production?` check.
  • Loading branch information
andymeneely committed Nov 18, 2019
1 parent 430bf24 commit 3a85f0f
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions app/views/vulnerabilities/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,5 @@ This DOM element is duplicated, populated, and then shown.
var vulnerability_id = <%= @vulnerability.id %>
</script>

<%= javascript_include_tag "timeline", async: Rails.env.production? %>
<%= javascript_include_tag "timeline/timelines", async: Rails.env.production? %>
<%= javascript_include_tag "vulnerabilities/show", async: Rails.env.production? %>
<%= javascript_include_tag "timeline/timelines" %>
<%= javascript_include_tag "vulnerabilities/show" %>

0 comments on commit 3a85f0f

Please sign in to comment.