Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a better logger that shows timing diffs #629

Merged
merged 13 commits into from Nov 18, 2019
Merged

Add a better logger that shows timing diffs #629

merged 13 commits into from Nov 18, 2019

Conversation

andymeneely
Copy link
Collaborator

Been meaning to do this - hopefully this better-formatted logging is easier to see where the performance bottlenecks are.

@andymeneely andymeneely added the refactor Improving code without changing functionality label Nov 12, 2019
@andymeneely andymeneely temporarily deployed to vulnerabilit-vhp-logger-xloedi November 12, 2019 04:36 Inactive
@coveralls
Copy link

coveralls commented Nov 12, 2019 •
edited

Pull Request Test Coverage Report for Build 1175

  • 58 of 59 (98.31%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 89.155%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/event_generators/weekly_report_events.rb 1 2 50.0%
Totals Coverage Status
Change from base Build 798: 0.4%
Covered Lines: 1340
Relevant Lines: 1503
💛 - Coveralls

@andymeneely andymeneely had a problem deploying to vulnerabilit-vhp-logger-xloedi November 12, 2019 16:15 Failure
@andymeneely andymeneely temporarily deployed to vulnerabilit-vhp-logger-xloedi November 12, 2019 16:19 Inactive
@andymeneely andymeneely had a problem deploying to vulnerabilit-vhp-logger-xloedi November 12, 2019 16:21 Failure
@andymeneely andymeneely temporarily deployed to vulnerabilit-vhp-logger-xloedi November 12, 2019 17:05 Inactive
andymeneely
andymeneely commented Nov 15, 2019
View reviewed changes
lib/tasks/chromium.rake Outdated Show resolved Hide resolved
@andymeneely andymeneely temporarily deployed to vulnerabilit-vhp-logger-xloedi November 15, 2019 16:35 Inactive
@andymeneely andymeneely temporarily deployed to vulnerabilit-vhp-logger-xloedi November 15, 2019 16:41 Inactive
@andymeneely andymeneely had a problem deploying to vulnerabilit-vhp-logger-xloedi November 15, 2019 16:50 Failure
@andymeneely andymeneely temporarily deployed to vulnerabilit-vhp-logger-xloedi November 15, 2019 19:28 Inactive
@andymeneely
Copy link
Collaborator Author

Ready to go now!

@andymeneely andymeneely temporarily deployed to vulnerabilit-vhp-logger-xloedi November 18, 2019 04:07 Inactive
@andymeneely
Copy link
Collaborator Author

@mesternefeld ok NOW it's good to go. approve?

mesternefeld
mesternefeld approved these changes Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@mesternefeld mesternefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! The checks pass now.

@andymeneely andymeneely merged commit d3da552 into master Nov 18, 2019
@andymeneely andymeneely deleted the vhp-logger branch November 18, 2019 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesternefeld mesternefeld mesternefeld approved these changes

Assignees
No one assigned
Labels
refactor Improving code without changing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andymeneely @coveralls @mesternefeld