Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 485: Add Articles Tabs #642

Merged
merged 8 commits into from
Feb 4, 2020
Merged

Issue 485: Add Articles Tabs #642

merged 8 commits into from
Feb 4, 2020

Conversation

mesternefeld
Copy link
Collaborator

Fixes #485
The beginning of the fixing of putting tabs everywhere.

@mesternefeld mesternefeld added the dont merge yet! Don't merge these pull requests yet label Nov 25, 2019
@coveralls
Copy link

coveralls commented Nov 25, 2019

Pull Request Test Coverage Report for Build 893

  • 0 of 4 (0.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 88.955%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/filepaths_controller.rb 0 1 0.0%
app/controllers/vulnerabilities_controller.rb 0 1 0.0%
app/controllers/tags_controller.rb 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
app/controllers/filepaths_controller.rb 1 39.29%
app/controllers/vulnerabilities_controller.rb 1 52.17%
Totals Coverage Status
Change from base Build 838: -0.2%
Covered Lines: 1345
Relevant Lines: 1512

💛 - Coveralls

@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-485-yxga68l November 25, 2019 19:07 Inactive
@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-485-yxga68l December 6, 2019 02:22 Inactive
@mesternefeld mesternefeld removed the dont merge yet! Don't merge these pull requests yet label Dec 6, 2019
@mesternefeld
Copy link
Collaborator Author

Add links to article show pages

@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-485-yxga68l December 9, 2019 01:16 Inactive
Copy link
Collaborator

@andymeneely andymeneely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we mentioned in this in meeting but I figured I'd write it here. Keep the headline black and make a link at the end like "Full article"

@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-485-yxga68l January 26, 2020 23:24 Inactive
@mesternefeld
Copy link
Collaborator Author

image
This is the link

@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-485-yxga68l January 29, 2020 23:01 Inactive
@mesternefeld
Copy link
Collaborator Author

Add


to tags page

</div>
<div class="cell medium-3"><div class="vhp-art-<%= article.art %>" /></div>
</div>
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</div>
</div>
<hr/>

@andymeneely andymeneely merged commit d73c6a0 into master Feb 4, 2020
@mesternefeld mesternefeld deleted the issue-485 branch February 20, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put Articles tabs everywhere
3 participants