Fix chiclets overlapping from rounding issues (#615) #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, I got a little carried away and did #679 at the same time.
Pull Request Test Coverage Report for Build 1243
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #615, we simply needed to account for the minutes when creating the interval for the horizontal timeline. Previously, an increment of some number of days would separate columns (e.g., 4.6 days). However, that decimal would create rounding issues which led to some of the columns appearing inconsistently spaced.
While I was verifying that my changes didn't ruin the ordering of the events in the timeline, I also encountered #679 and fixed it. That fix is also in this pull request.