-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accordion menus for vertical timeline events #738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1031
💛 - Coveralls |
This was referenced May 14, 2020
Also fixed the lines of code inserted and deleted not showing up in the weekly_overall description.
andymeneely
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683 by adding an accordion menu for all linked DB items (e.g., commits, developers, filepaths) in the vertical timeline events.
Blocked by #707 and related PRs. Other projects (Struts, Chromium, and Tomcat) will need to be changed once those PRs are merged.
Currently, most (if not all) linked commits aren't in our database, so the links don't go anywhere. For every commit hash and developer name not found in our database, I indicate this by adding either "(Untracked)" or "Unidentified Developer", respectively.
Also a part of this fix:
VulnerabilityHistoryProject/httpd-vulnerabilities#101
VulnerabilityHistoryProject/vhp-writing#6