Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accordion menus for vertical timeline events #738

Merged
merged 8 commits into from
Jun 5, 2020
Merged

Conversation

Xetnus
Copy link
Collaborator

@Xetnus Xetnus commented Mar 26, 2020

Fixes #683 by adding an accordion menu for all linked DB items (e.g., commits, developers, filepaths) in the vertical timeline events.

Blocked by #707 and related PRs. Other projects (Struts, Chromium, and Tomcat) will need to be changed once those PRs are merged.

Currently, most (if not all) linked commits aren't in our database, so the links don't go anywhere. For every commit hash and developer name not found in our database, I indicate this by adding either "(Untracked)" or "Unidentified Developer", respectively.

Also a part of this fix:
VulnerabilityHistoryProject/httpd-vulnerabilities#101
VulnerabilityHistoryProject/vhp-writing#6

@Xetnus Xetnus added the bug label Mar 26, 2020
@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-683-thrke4s March 26, 2020 16:29 Inactive
@Xetnus Xetnus added dont merge yet! Don't merge these pull requests yet and removed bug labels Mar 26, 2020
@coveralls
Copy link

coveralls commented Mar 26, 2020

Pull Request Test Coverage Report for Build 1031

  • 2 of 30 (6.67%) changed or added relevant lines in 3 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-2.0%) to 86.637%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/event_generators/weekly_report_events.rb 0 28 0.0%
Files with Coverage Reduction New Missed Lines %
lib/event_generators/weekly_report_events.rb 3 20.72%
test/lib/event_generators/release_events_test.rb 4 66.67%
test/lib/event_generators/all_vulnerability_events_test.rb 5 68.75%
Totals Coverage Status
Change from base Build 1030: -2.0%
Covered Lines: 1368
Relevant Lines: 1579

💛 - Coveralls

@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-683-thrke4s April 2, 2020 19:20 Inactive
@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-683-thrke4s April 6, 2020 21:42 Inactive
Also fixed the lines of code inserted and deleted not showing
up in the weekly_overall description.
@andymeneely andymeneely had a problem deploying to vulnerabilit-issue-683-thrke4s May 14, 2020 16:28 Failure
@andymeneely andymeneely temporarily deployed to vulnerabilit-issue-683-thrke4s June 5, 2020 14:52 Inactive
@andymeneely andymeneely merged commit d119f4e into master Jun 5, 2020
@andymeneely andymeneely deleted the issue-683 branch June 5, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont merge yet! Don't merge these pull requests yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide links to commits and filepaths in vertical timeline
3 participants