Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to visit the homepage of a Bundle #411

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a command to visit the homepage of a Bundle #411

wants to merge 1 commit into from

Conversation

lucc
Copy link
Contributor

@lucc lucc commented Mar 23, 2014

The command BundleVisitHomepage can will try to take the user to the homepage
or directory the bundle is cloned from.

This is not yet system independent and can not yet handle full git uris.

questions and ideas:
This is still work in progress. Do you think it is a feature that should be included into vundle?

It might be interesting for people who demanded some information on the plugins inside the search window where some key could be mapped to this function.

If you have ideas how to handle general git uris or open uris on different systems please comment. (What can you do on windows to open an uri? On linux we might try for xdg-open or are there many window managers and desktop environments that don't support it?)

@starcraftman
Copy link
Contributor

@lucc Thanks. This is an interesting idea, however at the moment if I understand this right it just opens a local URI with explore? How exactly were you thinking of tying this in? Via the interactive mode as a different button press maybe to open the Readme/doc.txt?

We previously mentioned in #403 that we might want a general means of seeing information on a plugin. I did some research and found this plugin > https://github.com/tyru/open-browser.vim. If this was a dependency, we could open local browser to whatever URI we cared for like the project web page.

@gmarik @jdevera Thoughts?

@lucc
Copy link
Contributor Author

lucc commented Mar 24, 2014

I like the plugin you mentioned and put it into code. This removes the trouble of writing code to open an url system independent. 👍

If you like it I can add documentation and change the name to suit the new names (Plugin*).

@jdevera
Copy link
Contributor

jdevera commented Apr 5, 2014

I'm a bit reluctant to take this as it currently is. The feature, I like, but the calling to another plugin, not so much.

First we need to make sure, or a good guess, that the uri is browseable, so we don't try to open a browser for an ssh backed repo. Then for windows, I think we can use simply open and pass the uri, but I'm not sure how it will take the file:// uri, maybe not so well. For linux we can try using xdg-open, wich takes care of http:// and file:// just fine. For mac, well, no idea 😄.

And after all this it still seems a bit brittle.

@lucc
Copy link
Contributor Author

lucc commented Apr 5, 2014

For Mac it is open :)
I will try to include some original code so that the Plugin is not needed.

@starcraftman
Copy link
Contributor

Just to be clear, I wasn't meaning to put the open-browser directly into your solution. It would be annoying as a user to have to have a second plugin to make vundle work. I guess I was more posting that as a related thing that might provide information.

@lucc
Copy link
Contributor Author

lucc commented Apr 23, 2014

I just found #302 to be related.

@lucc
Copy link
Contributor Author

lucc commented Apr 29, 2014

I rebased this on next and squashed the commits. It should only be merged after v0.10.2.

The open-browser plugin is used if it is available.  Else some simple tests
are made and the URL of the bundle is opened via the system's default
procedure.

TODO: test on different operating systems
@lucc
Copy link
Contributor Author

lucc commented Mar 22, 2015

Just rebased on current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants