Prevent insecure plugin names. #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -262,7 +265,7 @@ let s:bundle = {} | |||
| " return -- the target location to clone this bundle to | |||
| " --------------------------------------------------------------------------- | |||
| func! s:bundle.path() | |||
| return s:expand_path(g:vundle#bundle_dir.'/'.self.name) | |||
| return s:expand_path(g:bundle_dir.'/') . self.name | |||
There was a problem hiding this comment.
We really want to keep the vundle#bundle_dir here. Otherwise I cannot even test this :)
|
Oops... missed that. |
Plugins' names which contain '../', '$HOME', '%:h:h', '..\', etc. can be dangerous. Use a sensible whitelist for plugin names and prevent its expansion.
annagrram
force-pushed
the
plugin-names-security-enhancement
branch
from
e3320cc
to
2506347
Compare
|
Note to myself: "Check even the most trivial rebases" |
| @@ -97,6 +97,9 @@ funct! s:check_bundle_name(bundle) | |||
| \ ' previously used the name "' . a:bundle.name . '"' . | |||
| \ '. Skipping Plugin ' . a:bundle.name_spec . '.' | |||
| return 0 | |||
| elseif a:bundle.name !~ '\v^[A-Za-z0-9_-]%(\.?[A-Za-z0-9_-])*$' | |||
| echoerr 'Invalid plugin name: ' . a:bundle.name | |||
There was a problem hiding this comment.
When I run:
Plugin '..'
it shows me:
Error detected while processing function vundle#config#bundle..<SNR>10_check_bundle_name:
line 8:
Invalid plugin name: ..
So, cool :)
|
I'll merge it, hopefully people are not running plugins with funky names. |
jdevera
added a commit
that referenced
this pull request
Mar 21, 2015
Prevent insecure plugin names.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins' names which contain '../', '$HOME', '%:h:h', '..', etc.
can be dangerous.
Use a sensible whitelist for plugin names and prevent its expansion.