Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wa_purge #3

Closed
Vurv78 opened this issue Apr 25, 2021 · 1 comment · Fixed by #12
Closed

Add wa_purge #3

Vurv78 opened this issue Apr 25, 2021 · 1 comment · Fixed by #12
Labels
Complexity: Low Something that's easy to implement enhancement New feature or request

Comments

@Vurv78
Copy link
Owner

Vurv78 commented Apr 25, 2021 •
edited

Just loop through all clientside wa receivers in the Audios table and run IGmodAudioChannel:Stop() on them.
Also need to check the Enabled convar in the wa_modify net message so people can't modify audios if you set wa_enable to 0 after they made the object, which would cause errors with these stopped bass objects.
@Vurv78 Vurv78 added enhancement New feature or request good first issue Complexity: Low Something that's easy to implement labels Apr 25, 2021
@Vurv78
Copy link
Owner Author

Vurv78 commented Apr 27, 2021

Doing this alongside making wa_enable halt the server from sending useless net messages

Vurv78 added a commit that referenced this issue Apr 30, 2021
@Vurv78
Refactor a lot of stuff & Add a lot of functionality
591b852 
* Added wa_purge. Instantly kills and stops receiving data from every currently running stream on your client.

* Added setRadius, allows you to set the radius in which the stream can be heard from.

Along side this comes the convar:
* wa_radius_max

* On the lua (api) side, added static methods to streamline the stuff going on in the code. You should check out all of the new methods.
* wa_enable now has the same functionality as doing wa_purge if you set it to 0, no longer receiving any net messages from currently running streams and any future streams until you reenable it.

Fixes #3 #4 #6
@Vurv78 Vurv78 mentioned this issue Apr 30, 2021
Merged
Vurv78 added a commit that referenced this issue Apr 30, 2021
@Vurv78
Refactoring and Fixing 3 Issues (#12)
ea6a12e 
* Refactor a lot of stuff & Add a lot of functionality

* Added wa_purge. Instantly kills and stops receiving data from every currently running stream on your client.

* Added setRadius, allows you to set the radius in which the stream can be heard from.

Along side this comes the convar:
* wa_radius_max

* On the lua (api) side, added static methods to streamline the stuff going on in the code. You should check out all of the new methods.
* wa_enable now has the same functionality as doing wa_purge if you set it to 0, no longer receiving any net messages from currently running streams and any future streams until you reenable it.

Fixes #3 #4 #6

* Remove unused variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Low Something that's easy to implement enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring and Fixing 3 Issues Vurv78/WebAudio
1 participant
@Vurv78