Code cleanup and development freeze

[pxeger]

I want to cleanup and refactor all of Vyxal's code to be more stylistic under PEP 8 and what-not. Currently, not only is the code syntactically all ugly inconsistent with the standards, but it's not very maintainable because of its structure (e.g. the interpreter core is all in one file)

However, to prevent massive merge conflicts, this would have to be done with a halt of all other development.

My suggestion is to warn people that, on some pre-determined date, they must have finished whatever they're working on, and not start working on something else (unless they're masochists and want to deal with those conflicts). I will then clean up the code (with modern auto-formatters and refactoring tooling it shouldn't be too big an undertaking), and everyone else can update their forks and continue working on stuff thence.

For long-running projects like the e branch, and my idea to rework the compiler to use bytecode, (depending on their state when we reach that point) they should be refactored independently so they don't have to be finished by that point.

What are your thoughts?

[ysthakur]

Yes please. I propose we have different files for different categories of builtins and use proper functions instead of evaluated strings for commands.py, at the very least.

[pxeger]

If my bytecode compiling idea gets implemented, it will necessitate solving this issue too

[mathcat4]

Nice idea, not including comments, right?

[pxeger]

We can clean up the comments too, like remove typos and perhaps move them around on screen if necessary. And add more!

[mathcat4]

Yes, nice!

[ysthakur]

I'd also like to propose that we all format our code with the same formatter before committing any changes, preferably black. black can also be used online.

[mathcat4]

Yes, black's great

[ysthakur]

Every (important) function and class should also have detailed docstrings to help maintainers.

[ysthakur]

Strawpoll for when we freeze development if this is accepted. You can choose multiple answers

[UnrelatedString]

I'm not familiar enough with the branch/fork structure to say how much of a pain that might be to deal with, but I would make a cleanup a very high priority. Any branches with functionality meant to be incorporated into master should do so as soon as possible.

[ysthakur]

Yeah, it's going to be a problem updating the experimental branch especially.

[ysthakur]

Project to plan this and flesh it out a bit more.

[lyxal]

Well then. We shall have a clean up.

[chunkybanana]

I would help but I think I'd mess it up more...

[pxeger]

This is irrelevant now, so I'm closing.