Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested modifiers' arity #1309

Merged
merged 7 commits into from
Jul 15, 2022
Merged

Fix nested modifiers' arity #1309

merged 7 commits into from
Jul 15, 2022

Conversation

Steffan153
Copy link
Contributor

Closes #1252

@Vyxal-Bot-old Vyxal-Bot-old added the PR: Bug Fix PR only tag - a PR that is fixing a bug/issue label Jul 14, 2022
chunkybanana
chunkybanana reviewed Jul 14, 2022
View reviewed changes
vyxal/transpile.py Outdated Show resolved Hide resolved
Steffan153
Steffan153 commented Jul 14, 2022
View reviewed changes
vyxal/transpile.py Outdated Show resolved Hide resolved
@chunkybanana
Copy link
Member

chunkybanana commented Jul 14, 2022 •
edited
Loading

This might also fix #1195 - EDIT: no, it does not.

@lyxal lyxal merged commit e41ef1f into main Jul 15, 2022
@lyxal lyxal deleted the nested-modifier-arity branch July 15, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyxal lyxal lyxal approved these changes

@chunkybanana chunkybanana chunkybanana approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix PR only tag - a PR that is fixing a bug/issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested modifiers don't retain arity
4 participants
@Steffan153 @chunkybanana @lyxal @Vyxal-Bot-old