Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ) as lambda to newline, and make only } close all structures #1424

Merged
merged 12 commits into from
Oct 2, 2022
Merged

Add ) as lambda to newline, and make only } close all structures #1424

merged 12 commits into from
Oct 2, 2022

Conversation

lyxal
Copy link
Member

@lyxal lyxal commented Sep 4, 2022 •
edited
Loading

Closes #1342

@lyxal lyxal added PR: Enhancement PR only tag - for enhancements PR: Careful Review Required PR only tag - PRs that handle issues tagged difficulty very hard labels Sep 4, 2022
Steffan153
Steffan153 requested changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@Steffan153 Steffan153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the rest of the closing characters functioning as before.

Steffan153
Steffan153 requested changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@Steffan153 Steffan153 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still isn't how it was before - }]; should not necessarily close all structures, so [{(...} will only close the for-loop (so it's equivalent to [{(...)}).

@chunkybanana
Copy link
Member

^

Steffan153
Steffan153 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@Steffan153 Steffan153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lyxal lyxal merged commit db6cd59 into main Oct 2, 2022
@lyxal lyxal deleted the lambda-to-newline branch October 2, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steffan153 Steffan153 Steffan153 approved these changes

Assignees
No one assigned
Labels
PR: Careful Review Required PR only tag - PRs that handle issues tagged difficulty very hard PR: Enhancement PR only tag - for enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lambda to newline
3 participants
@lyxal @chunkybanana @Steffan153