Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make grouping modifiers work properly #1452

Merged
merged 3 commits into from
Oct 2, 2022
Merged

Make grouping modifiers work properly #1452

merged 3 commits into from
Oct 2, 2022

Conversation

lyxal
Copy link
Member

@lyxal lyxal commented Sep 30, 2022

Closes #1195

Steffan153
Steffan153 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@Steffan153 Steffan153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have any tests to check that it leaves whatever junk was on the stack where it was.

Steffan153
Steffan153 requested changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@Steffan153 Steffan153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAAAAA

@lyxal lyxal merged commit 02a4156 into main Oct 2, 2022
@lyxal lyxal deleted the fix-parallel-application-modifiers branch October 2, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steffan153 Steffan153 Steffan153 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grouping modifiers are very sus
2 participants
@lyxal @Steffan153