Create tests.yaml and an accompanying test suite #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyxal
reviewed
Mar 20, 2023
lyxal
reviewed
Mar 20, 2023
lyxal
added
version-3
lyxal
previously approved these changes
Mar 25, 2023
|
Converting to draft since it's got an approval and I don't want to accidentally merge it |
|
We might want to have a way for entire test groups to specify custom code to be run, rather than individual tests. Not sure how useful that'd be, though, so maybe we can wait for a use case to arise before actually implementing it. |
lyxal
reviewed
May 24, 2023
lyxal
approved these changes
May 24, 2023
Feel like that'd be better as just using a testing class. The yaml should be for data in data out tests imo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting tests in a tests.yaml will let HN get examples for free, and I guess it'll be more concise than what we have now. This PR adds a
YamlTeststest suite, but that needs some work, so this is only a draft for now.