Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export lexing to the JavaScript module #2047

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Export lexing to the JavaScript module #2047

merged 2 commits into from
Jan 8, 2024

Conversation

RubenVerg
Copy link
Member

Because Lexer.lexLiterate turns Token.value into its SBCS counterpart, the exported vyxal/Vyxal.lexLiterate does the same. Original input can however be trivially reconstructed using the startOffset and endOffset properties on JSToken

@RubenVerg RubenVerg marked this pull request as ready for review January 8, 2024 19:56
ysthakur
ysthakur approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@ysthakur ysthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ysthakur ysthakur merged commit e0fa25a into version-3 Jan 8, 2024
3 checks passed
@ysthakur ysthakur deleted the v3-js-export-lexer branch January 8, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysthakur ysthakur ysthakur approved these changes

Assignees
No one assigned
Labels
PR: Version 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RubenVerg @ysthakur