Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REPL stops printing after a print element is ran #2057

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix REPL stops printing after a print element is ran #2057

merged 1 commit into from
Jan 10, 2024

Conversation

RubenVerg
Copy link
Member

This fixes a bug where after executing a print element in a REPL, all the next input lines don't get the automatically-print-the-top-of-the-stack behavior.

@RubenVerg
Fix REPL stops printing after a print element is ran
6f69989 
This fixes a bug where after executing a print element in a REPL, all the next input lines don't get the automatically-print-the-top-of-the-stack behavior.
ysthakur
ysthakur approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@ysthakur ysthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was going to suggest setting it to false inside Interpreter.execute, but that may mess with executing functions at the end before you print the results

@ysthakur ysthakur merged commit 93bba4f into version-3 Jan 10, 2024
8 checks passed
@ysthakur ysthakur deleted the v3-fix-repl-stops-printing branch January 10, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysthakur ysthakur ysthakur approved these changes

Assignees
No one assigned
Labels
PR: Version 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RubenVerg @ysthakur