rename drop to drop/zero slice from #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysthakur
requested changes
Jan 11, 2024
shared/src/vyxal/Elements.scala
Outdated
Comment on lines
1074
to
1075
| "Zero Slice From | Collect While Unique | Complex Number", | ||
| List("zero-slice-from", "slice-from", "from", "drop-from", "collect-while-unique", "complex"), |
There was a problem hiding this comment.
Suggested change
| "Zero Slice From | Collect While Unique | Complex Number", | |
| List("zero-slice-from", "slice-from", "from", "drop-from", "collect-while-unique", "complex"), | |
| "Drop | Collect While Unique | Complex Number", | |
| List("zero-slice-from", "slice-from", "drop", "collect-while-unique", "complex"), |
The zero-slice-from and slice-from keywords are a good idea, but drop is also a common name for this operation (also, I've never seen anyone call it drop-from)
There was a problem hiding this comment.
Personally, I've never heard of drop. I like the keywords, but maybe we could call it "Zero Slice From/Drop"?
There was a problem hiding this comment.
@RubenVerg Alright, I've changed it to Drop/Zero Slice From.
TheSecondComing123
added
PR: Documentation Fix
TheSecondComing123
changed the title
ysthakur
approved these changes
Jan 11, 2024
|
Wait, there's still a problem. Some of the keywords aren't implemented in literate mode (e. g. |
|
What error are you getting? I tried locally and it's lexed correctly |
|
@ysthakur Oh woah it suddenly worked I must have tested it wrong. |
|
Awesome, good to hear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.