Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make trigraphs in digraphs work #2063

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Make trigraphs in digraphs work #2063

merged 3 commits into from
Jan 16, 2024

Conversation

ysthakur
Copy link
Member

Now digraphs whose first or second character is a trigraph should work

@ysthakur ysthakur requested a review from lyxal January 13, 2024 22:27
lyxal
lyxal requested changes Jan 13, 2024
View reviewed changes
Copy link
Member

@lyxal lyxal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where tests

@ysthakur ysthakur marked this pull request as draft January 13, 2024 23:33
@ysthakur ysthakur marked this pull request as ready for review January 15, 2024 18:04
@ysthakur
Copy link
Member Author

@lyxal Test added

@lyxal lyxal merged commit ff426b4 into version-3 Jan 16, 2024
8 checks passed
@lyxal lyxal deleted the digraph-trigraphs branch January 16, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyxal lyxal lyxal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ysthakur @lyxal