Made link open a new tab #221
Conversation
I wouldn’t want my code to disappear when I want to, say, look up a command or star the repo
|
Sounds like a good idea to me. |
ysthakur
requested review from
lyxal,
ysthakur,
Vyxal-Bot-old and
vyxal-cookie
|
@vyxal-cookie May I take your review as a serious one and merge this? I have no idea who you are but I'm assuming you're one of the actual contributors. |
|
Thanks! Why’d the docs update fail? I don’t think adding an html attribute interferes with building docs, it says there was a 403 error fetching the git thingy. (Also yes I don’t know who vyxal-cookie is 🤷♂️) |
|
@Electogenius Don't worry about that, it's just because the Update docs workflow pushes to master and it can't do that right now because it's a different branch. It always fails on PRs. (I shouldn't have run the workflows in the first place, there was nothing to test) As for vyxal-cookie, we're not sure which one of us that is. It's probably not lyxal or hyper-neutrino, and pxeger claims it's not his. |
ysthakur
removed request for
lyxal,
AMiller42,
pxeger,
Vyxal-Bot-old and
vyxal-cookie
| @@ -196,7 +196,7 @@ | |||
| <body onload="initCodeMirror(); decodeURL(); updateCount()"> | |||
| <textarea id=dummy style="visibility: hidden;position:absolute; height: 0px; font: size 20px;"></textarea> | |||
| <session-code>{{session}}</session-code> | |||
| <h2 style="display: inline-block;"><a href="https://github.com/Vyxal/Vyxal">Vyxal</a></h2> | |||
| <h2 style="display: inline-block;"><a href="https://github.com/Vyxal/Vyxal" onclick="window.open('https://github.com/Vyxal/Vyxal')">Vyxal</a></h2> | |||
There was a problem hiding this comment.
What's wrong with <a ... target="_blank">...</a>?
There was a problem hiding this comment.
That's what I found on SO too, but this works, so ¯\(ツ)/¯.
pxeger [pointed out](#221 (comment)) that `window.open` was unnecessary.
|
Thanks! I didn’t know |
I wouldn’t want my code to disappear when I want to, say, look up a command or star the repo.
Note that I haven’t tested if this works yet but it probably works