-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate tests in the test workflow #533
Conversation
I think we should add a separate CI check to ensure this file (and the others generated from But this is a good step for now |
No squash please |
Why no squash? |
Because it obscures commit history which carries useful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to install yaml
first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add something later for documentation rerolling
Sounds good, although generating documentation should go in its own workflow. |
i've always wanted to dismiss a review
Co-authored-by: Patrick Reader <_@pxeger.com>
Co-authored-by: Patrick Reader <_@pxeger.com>
There are so many commits that at this point we might as well squash them or make a new branch and add those in manually. |
I still don't like squashing, but whatever |
I mean, we could make a new branch and add those commits in again. It's just that this particular history is crazy. |
You know what, I'm too lazy to do that, so here we go. And fwiw, tennis > badminton. |
I just realized I made a mistake in elements.yml but it wasn't noticed because the tests weren't regenerated, which is not good.