Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate tests in the test workflow #533

Merged
merged 8 commits into from
Dec 29, 2021
Merged

Generate tests in the test workflow #533

merged 8 commits into from
Dec 29, 2021

Conversation

cgccuser
Copy link
Member

I just realized I made a mistake in elements.yml but it wasn't noticed because the tests weren't regenerated, which is not good.

@pxeger
Copy link
Collaborator

pxeger commented Dec 28, 2021

I think we should add a separate CI check to ensure this file (and the others generated from elements.yaml) get regenerated? I think that could be done with https://pre-commit.ci pretty easily.

But this is a good step for now

@cgccuser cgccuser enabled auto-merge (squash) December 28, 2021 23:53
@pxeger
Copy link
Collaborator

pxeger commented Dec 28, 2021

No squash please

@cgccuser
Copy link
Member Author

Why no squash?

@pxeger
Copy link
Collaborator

pxeger commented Dec 28, 2021

Badminton's just better

Because it obscures commit history which carries useful information.

pxeger
pxeger previously requested changes Dec 28, 2021
Copy link
Collaborator

@pxeger pxeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to install yaml first

Copy link
Member

@lyxal lyxal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add something later for documentation rerolling

@cgccuser
Copy link
Member Author

Sounds good, although generating documentation should go in its own workflow.

pxeger
pxeger previously requested changes Dec 29, 2021
.github/workflows/run-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/run-tests.yaml Outdated Show resolved Hide resolved
@cgccuser cgccuser dismissed pxeger’s stale review December 29, 2021 00:00

i've always wanted to dismiss a review

cgccuser and others added 2 commits December 28, 2021 19:01
Co-authored-by: Patrick Reader <_@pxeger.com>
Co-authored-by: Patrick Reader <_@pxeger.com>
@cgccuser cgccuser requested a review from pxeger December 29, 2021 00:01
@cgccuser
Copy link
Member Author

There are so many commits that at this point we might as well squash them or make a new branch and add those in manually.

@pxeger
Copy link
Collaborator

pxeger commented Dec 29, 2021

I still don't like squashing, but whatever

@cgccuser
Copy link
Member Author

cgccuser commented Dec 29, 2021

I mean, we could make a new branch and add those commits in again. It's just that this particular history is crazy.

@cgccuser
Copy link
Member Author

You know what, I'm too lazy to do that, so here we go. And fwiw, tennis > badminton.

@cgccuser cgccuser merged commit df679be into main Dec 29, 2021
@cgccuser cgccuser deleted the gen-tests branch December 29, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants