Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vectorised recursion (vx) work again #990

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Make vectorised recursion (vx) work again #990

merged 5 commits into from
Jun 29, 2022

Conversation

Steffan153
Copy link
Contributor

@Steffan153 Steffan153 commented May 16, 2022 •
edited
Loading

makes the transpiler use the function_stack instead of this

#857 broke this, btw.

@lyxal lyxal changed the title dirty hack Make vectorised recursion (vx) work again May 17, 2022
@lyxal lyxal added PR: Bug Fix PR only tag - a PR that is fixing a bug/issue PR: Careful Review Required PR only tag - PRs that handle issues tagged difficulty very hard labels May 17, 2022
@chunkybanana
Copy link
Member

Make some tests plz

@Steffan153 Steffan153 self-assigned this May 23, 2022
@chunkybanana
Copy link
Member

MAKE SOME TESTS PLZ

@Steffan153
Copy link
Contributor Author

Btw the reason I haven't added tests yet is because it doesn't work atm

@Steffan153 Steffan153 marked this pull request as draft May 26, 2022 18:17
@lyxal lyxal self-assigned this Jun 27, 2022
@Steffan153
Copy link
Contributor Author

Alr yay this works now let's add tests now

@Steffan153 Steffan153 marked this pull request as ready for review June 27, 2022 16:58
@lyxal lyxal mentioned this pull request Jun 28, 2022
Closed
Steffan153 and others added 4 commits June 28, 2022 21:28
@Steffan153
dirty hack
d437529 
makes the transpiler use the function_stack instead of this
@lyxal @Steffan153
Maybe (?) fix it
d24fc8b
@Steffan153
Add test
e322aa6
@pre-commit-ci @Steffan153
[pre-commit.ci] auto fixes from pre-commit.com hooks
78fc709 
for more information, see https://pre-commit.ci
@cgccuser cgccuser merged commit 8c5e60d into main Jun 29, 2022
@cgccuser cgccuser deleted the dirty-hack branch June 29, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyxal lyxal lyxal approved these changes

@chunkybanana chunkybanana chunkybanana approved these changes

@cgccuser cgccuser Awaiting requested review from cgccuser

Assignees

@lyxal lyxal

@Steffan153 Steffan153

Labels
PR: Bug Fix PR only tag - a PR that is fixing a bug/issue PR: Careful Review Required PR only tag - PRs that handle issues tagged difficulty very hard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Steffan153 @chunkybanana @lyxal @cgccuser