Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bug fixes and changes #64

Merged
merged 1 commit into from
Aug 16, 2020
Merged

Conversation

Zzombiee2361
Copy link
Collaborator

- Removed waStore since window.Store is already loaded by whatsapp-web.js
- Removed dark mode toggle since whatsapp officially supports it
- Better window.Store detection on preload.js
- Added Ctrl+Q shortcut to exit WALC (issue WAClient#43)
- Immediately retry connecting to whatsapp when internet is online
@Zzombiee2361 Zzombiee2361 merged commit 274b0f8 into WAClient:master Aug 16, 2020
@Zzombiee2361
Copy link
Collaborator Author

@cstayyab how do I make releases? Do I just upload the AppImage file? What's latest-linux.yml for? What about snap? Any better way to contact you other than github mentions?

@cstayyab
Copy link
Collaborator

cstayyab commented Aug 16, 2020

how do I make releases?

I would like to work on releases myself.

Any better way to contact you other than github mentions?

You can contact me on my email address, you will find it on my profile.

@Zzombiee2361
Copy link
Collaborator Author

Alright then, but make sure to check the library inside AppImage like mentioned here #42 (comment). It causes a lot of issues.

Please release a new version soon, I already put the changes and bumped the version.

@cstayyab
Copy link
Collaborator

The issues caused by that library will not be addressed in release 0.1.11. I have release 0.1.11 version and starting working on that issue. I hope it will be fixed in release 0.1.12.

@Zzombiee2361
Copy link
Collaborator Author

What do you mean? What needs to be fixed? When I built the AppImage myself it's fine, all libraries inside is normal. No zero sized library.

@cstayyab
Copy link
Collaborator

The issues exist for Manjaro and Arch based systems. I will have to verify WALC on different linux distros. I will be going for Manjaro first.

@cstayyab
Copy link
Collaborator

I will get back to you with more research.

@Zzombiee2361
Copy link
Collaborator Author

But it also happens on Ubuntu as well. You made sure that the libraries inside AppImage files aren't zero sized? I'm 100% sure that's the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] it doesn't recognize ctrl+q or ctrl+w to exit (completely colse) the application
2 participants