-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling and extending the search bar #1460
Comments
add select2 for search bar
Can the new search be added to this page https://scholia.toolforge.org/search? @DanielFLopez |
Do you mean the select2 plugin? We think that the advanced search has some special characteristics, such as the identification of Doi and arXiv, this requires certain validations and handling of special cases, so it should be kept on the backend side, with the plugin all these cases should be moved to the font. @carlinmack |
I think you're misunderstanding me. The search with autocomplete is already available on the home page and every other page. This search box https://scholia.toolforge.org/search does not have the autocomplete. |
Yes, that's because Select2 can also retrieve results from other data sources, like a remote JSON API, the search from the main page works that way, but the advanced search processes the text in the backend to detect the Doi, arXiv codes and it redirects them to their pages, why then what would be the difference between the home search and advance search? |
I guess I kind of understand, however I still think that all search boxes should be as powerful as they can be. As in, I don't see why the search results page search box doesn't have the autocomplete. I think at this point it would be easier for me to make the PR myself? |
@fnielsen can this be closed? or anything else to be done |
@carlinmack, one thing I don't like of the new search functionality is that I have to click twice before I can start typing. First click is to get the new UI, resulting in (without cursor focus): and then a second click is needed to give focus to the second search so that I can type things: |
Yeah I think it's due to the plugin being used (select2) is meant to be used for dropdowns rather than search input. I would suggest instead using the HTML < datalist> element to provide the autocomplete |
Styling and extending the search bar in the menu and on the front page. Make it more similiar the search bar on Wikidata.
The text was updated successfully, but these errors were encountered: