Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add country-level citation graph per topic #1102

Merged
merged 3 commits into from
Jun 16, 2020

Conversation

Daniel-Mietchen
Copy link
Member

First attempt at #1101.

Worked for all the about two dozen topics I tested, except for https://tools.wmflabs.org/scholia/topic/Q3450985 (neurodevelopmental disorders), which gave an empty response.

@Daniel-Mietchen
Copy link
Member Author

Another quirk: for microstructure, the flag for South Africa was just shown as the flag from the Apartheid period. This was easily fixed but should be kept in mind.

Also, while tracking this down, I was reminded that we have flag image (P41), which will likely make the query faster.

Screenshot_2020-04-06 Scholia

@Daniel-Mietchen
Copy link
Member Author

The solution to the question as to why https://tools.wmflabs.org/scholia/topic/Q3450985 (neurodevelopmental disorders) did not yield any result was simply that there were too few topic annotations (15 right now).

Screenshot_2020-04-06 Wikidata Query Service

I am starting a first batch towards changing that.

Copy link
Collaborator

@egonw egonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the tox report and there are no problems. I still have trouble interpreting the arrows, and I am a bit worried that it will overemphasize the work in the USA and I'm afraid it will further stress the "winner takes all" situation in science (no direct reason to not accept it).

@egonw egonw added the ready for merge label to flag a pull request ready for decision by the gatekeeper for merge into master label Jun 7, 2020
@fnielsen
Copy link
Collaborator

I am unfamiliar with the target: notation.

@fnielsen fnielsen merged commit b881650 into master Jun 16, 2020
@Daniel-Mietchen
Copy link
Member Author

@fnielsen See #431 for the target: notation.

@Daniel-Mietchen Daniel-Mietchen deleted the Daniel-Mietchen-country-topic-citation-network-1101 branch June 16, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge label to flag a pull request ready for decision by the gatekeeper for merge into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants