-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DOI to QuickStatements #2340
Conversation
9fb0783
to
848ab06
Compare
128d02b
to
85c88c2
Compare
@carlinmack maybe interesting for you, Tiago and I have written a data model and utilities for quickstatements in Python: https://github.com/cthoyt/quickstatements_client. This could help reduce error-prone code in scholia |
from feedparser import parse as parse_api | ||
|
||
from flask import current_app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In command-line applications the webapp may not be running
Closed in favour of #2453 |
Builds on top of #2337. Merge #2337 before this PR
Roadmap
#2337: Add support for multiple ArXiv IDs
This PR: Add support for other identifiers (DOI for now) and change name
#2342: Add new tool which allows users to query for most recent papers which will be sent to this tool for finding presence in Wikidata and creating Quickstatements (CC @Daniel-Mietchen)
PR I'd like to do if I can:
Description
Introduces DOI to QuickStatements (using the Crossref API) resulting in renaming the tool to Identifier to QuickStatements.
Note that this does not affect the current
/doi/[doi]
tool which creates QuickStatements using Citations.js and has different behaviour.Caveats
If you make changes to the Python code
Testing
Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.
string_to_type
Checklist