Type property pto sim #1064
Merged
Type property pto sim #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleonqu
force-pushed
the
typePropertyPTOSim
branch
from
f5f6688
to
cd3281f
Compare
|
Just looked over this PR and the updates look good and running smoothly with the corresponding WEC-Sim Applications PR. |
|
@jleonqu this looks good to me. I'm going to merge it, along with WEC-Sim/WEC-Sim_Applications#33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the 'type' property definition for PTO-Sim blocks. Now the 'type' property is similar to the waveClass 'type' property.
This is the new 'type' property definition:
type: This property must be defined to specify the type of block that will be used. The type value of each block is presented below:
type = 'electricGen' ---- Electric generator equivalent circuit
type = 'hydraulicCyl' ---- Hydraulic cylinder
type = 'hydraulicAcc' ---- Hydraulic accumulator
type = 'rectCheckValve' ---- Rectifying check valve
type = 'hydraulicMotor' ---- Hydraulic motor
type = 'linCrank' ---- Linear crank
type = 'adjustableRod' ---- Adjustable rod
type = 'checkValve' ---- Check valve
type = 'ddLinearGen' ---- Direct drive linear generator
type = 'ddRotaryGen' ---- Direct drive Rotary generator