Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End Stop Implementation #445

Merged
merged 47 commits into from Oct 30, 2020
Merged

End Stop Implementation #445

merged 47 commits into from Oct 30, 2020

Conversation

dforbush2
Copy link
Contributor

@dforbush2 dforbush2 commented Oct 30, 2020

This is the end-stop implementation. Library saved as 2019a. Including doc updates for End-Stops and Drag Body #423

lilnguy and others added 30 commits August 21, 2020 17:24
This commit has verified the implementatino of the normal and tangential Morison Element written by the initial pull request developer. The WEC-Sim team has chosen to keep both implementations active for users. Therefore, additional code development was needed to make this possible for the end user.
Updating the Morison Element documentation to reflect the two modeling approaches provided for the user.
Updating the WECSim_Lib.slx.

It appears that the conflict resolution over wrote the updates in the Morison Element block. Therefore, had to reconfigure the ME and make a correction in the calculation as well.
Adding to the documentation after being able to compile locally.
Update the WECSim_Lib.slx to fix broken links in the Flex Body block.
Fix the path issue for reading the two wave files when using PCT
Update the PCT documentation
yuyihsiang and others added 4 commits October 30, 2020 10:35
Add warning('off', 'MATLAB:MKDIR:DirectoryExists'); to wecSimPCT.m
Remove the makewecSimFcn.m since it has been renamed.
remove the "warning off" from wecSimFcn.m since they are no longer needed.
Code updates were made to the bodyClass.m and wecSim.m files to check when using option 1 for the Morison Element that the body(i).morisonElement.z vector is a unit normal vector.
@kmruehl kmruehl changed the title Dev End Stop Implementation Oct 30, 2020
Fix userDefineFunctions.
@kmruehl kmruehl self-requested a review October 30, 2020 17:26
@dforbush2
Copy link
Contributor Author

dforbush2 commented Oct 30, 2020

Changes to the library are to the mask initialization functions of

Constraints/Translational
Constraints/Rotational
PTOs/Translational PTO
PTOs/Rotational PTO
PTOs/Translational PTO Actuation Force
PTOs/Rotational PTO Acutation Force
PTOs/Translational PTO Actuation Motion
PTOs/Rotational PTO Actuation Motion

And also to the $/(Joint Primitive)/Limits sub-fields (must expand "Specify Lower Limit" and "Specify Upper Limit") of each of the above, for example

image

PLEASE ENSURE SPECIFY LOWER LIMIT AND SPECIFY UPPER LIMIT ARE UNCHECKED WHEN SAVING LIBRARY

nathanmtom and others added 6 commits October 30, 2020 11:57
Updated the attached files to keep simu.morisonElement = 1 the same as the past implementation which setting simu.morisonElement = 2 for the new normal and tangential formulation.
)

* Fix MATLAB Parallel Computing Toolbox support issue

* adding PCT to docs

* renamed to wecSimPCT and minor update to wecSimMCR

* cleaning up batch run scripts removing commented lines

* Update wecSim.m

Fix the path issue for reading the two wave files when using PCT

* Update advanced_features.rst

Update the PCT documentation

* renaming to wecSimFcn

* Remove warning

Add warning('off', 'MATLAB:MKDIR:DirectoryExists'); to wecSimPCT.m

* updates

Remove the makewecSimFcn.m since it has been renamed.
remove the "warning off" from wecSimFcn.m since they are no longer needed.

* Update wecSim.m

Fix userDefineFunctions.

Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>
@kmruehl kmruehl added Feature new feature request Constraint Class Constraint Class (constraintClass.m) PTO Class Power Take-off Class (ptoClass.m) labels Oct 30, 2020
nathanmtom and others added 5 commits October 30, 2020 15:22
Update the WECSim_Lib.slx Flex Body block. The wave diffraction and excitation block as well as the hydrostatic restoring block cannot be linked to their equivalent block in the rigid body block.
@kmruehl
Copy link
Contributor

kmruehl commented Oct 30, 2020

@dforbush2 thank you! Merging now

@kmruehl kmruehl merged commit 2a7a11c into WEC-Sim:dev Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Constraint Class Constraint Class (constraintClass.m) Feature new feature request PTO Class Power Take-off Class (ptoClass.m)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants