Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for direction in readCapytaine #999

Merged
merged 4 commits into from Mar 2, 2023

Conversation

akeeste
Copy link
Contributor

@akeeste akeeste commented Feb 23, 2023

This PR solves #997 and updates:

  • readCapytaine to convert direction from radians (Capytaine's convention) to degrees (WEC-Sim's convention)
  • updates examples/BEMIO/Capytaine scripts to use radians, not degrees
  • updates examples/BEMIO/Capytaine results

@akeeste akeeste added Bug bug in WEC-Sim source, high priority BEM/BEMIO related to BEMIO or BEM hydro data labels Feb 23, 2023
Copy link
Contributor

@dforbush2 dforbush2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, fixes the wave direction input in Capytaine input to be in radians in example runs, and fixes readCapytaine to convert radian capytaine output to be in degrees, as appropriate for WEC-Sim. Addresses #997

@dforbush2 dforbush2 marked this pull request as ready for review February 23, 2023 21:05
@dforbush2
Copy link
Contributor

only outstanding item is to update run capytaine results with the new input files.

@dforbush2
Copy link
Contributor

@akeeste would you be able to re-run the example files and push corrected outputs or should I? Be good to merge this ASAP

@akeeste
Copy link
Contributor Author

akeeste commented Feb 27, 2023

@dforbush2 I am running the OSWEC example now and then will finish up the last too expensive cases (RM3, COER_COMP). Should be done soon.

@akeeste
Copy link
Contributor Author

akeeste commented Mar 1, 2023

@dforbush2 the new output data is complete and all my tasks are finished on this PR. In addition to the tasks above, I added minor clean-up on the headers that Spyder puts in python files by default. This is good to go on my end

@dforbush2 dforbush2 merged commit 6fcb8ca into WEC-Sim:master Mar 2, 2023
akeeste added a commit that referenced this pull request Mar 15, 2023
Pull bug fixes #954, #999, #1002 from master into dev
@akeeste akeeste deleted the bug_readCapytaine_dir branch March 27, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BEM/BEMIO related to BEMIO or BEM hydro data Bug bug in WEC-Sim source, high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants