New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for direction in readCapytaine #999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, fixes the wave direction input in Capytaine input to be in radians in example runs, and fixes readCapytaine to convert radian capytaine output to be in degrees, as appropriate for WEC-Sim. Addresses #997
only outstanding item is to update run capytaine results with the new input files. |
@akeeste would you be able to re-run the example files and push corrected outputs or should I? Be good to merge this ASAP |
@dforbush2 I am running the OSWEC example now and then will finish up the last too expensive cases (RM3, COER_COMP). Should be done soon. |
@dforbush2 the new output data is complete and all my tasks are finished on this PR. In addition to the tasks above, I added minor clean-up on the headers that Spyder puts in python files by default. This is good to go on my end |
This PR solves #997 and updates:
readCapytaine
to convert direction from radians (Capytaine's convention) to degrees (WEC-Sim's convention)examples/BEMIO/Capytaine
scripts to use radians, not degreesexamples/BEMIO/Capytaine
results