Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sigils, remove request, clean up file generation #63

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

TobiTenno
Copy link
Member

@TobiTenno TobiTenno commented Aug 28, 2020

Warframe Drop Data Site Pull Request


What I did:

  • Add generic functions for anything "drop by avatar"
  • Add sigils
  • Remove request (deprecated)
  • Make all of the files that are generated in the same way use the same function

let's closes #44 too, cause i don't think we need to change it at this point


Why I did it:
closes #43
closes #53
cleans up codebase
better forward reliability


Fixes issue (include link):
#53, #43


Mockups, screenshots, evidence:
image


Was this an issue fix or a suggestion fulfillment?

@TobiTenno TobiTenno temporarily deployed to warframe-drops-pr-63 August 28, 2020 13:41 Inactive
@TobiTenno TobiTenno temporarily deployed to warframe-drops-pr-63 August 28, 2020 13:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sigils Should we change the format? Add "Resource by Avatar" and "Resource by Drop"
2 participants