Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add include guards (or pragma once) to ring and inplace_function headers #75

Closed
onqtam opened this issue Oct 7, 2016 · 1 comment
Closed

add include guards (or pragma once) to ring and inplace_function headers #75

onqtam opened this issue Oct 7, 2016 · 1 comment

Comments

@onqtam
Copy link

onqtam commented Oct 7, 2016 •
edited
Loading

No description provided.

@onqtam onqtam changed the title add include guards (or pragma once) to ring and inplace_function add include guards (or pragma once) to ring and inplace_function headers Oct 7, 2016
@carlcook
Copy link
Member

Good catch. I'll add the guards to inplace function now. @hatcat and @SuperV1234 , would you mind doing the same for the ring buffer?

Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue Apr 15, 2017
@Quuxplusone
#pragma once all the things!
bcdab21 
After this change,

    find . -name '*.h' | xargs head -1

shows that every .h file in the repo correctly begins with `#pragma once`.
A few of them have include guards *also*, so the style isn't completely
uniform; but at least none of them are completely unprotected anymore.

Fixes WG21-SG14#75.
@Quuxplusone Quuxplusone mentioned this issue Apr 15, 2017
Closed
Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue May 12, 2017
@Quuxplusone
Several cleanups to "ring.h".
d46b84d 
- Add `#pragma once`.
- Add a non-member ADL swap() for rings.
- Fix up the namespace of operator+= and operator-= for ring iterators.
- Fix up (it + n) and (it - n) for ring iterators.
- Add (it - it) for ring iterators.
- Fix a typo in (a >= b) for ring iterators, and make (a <= b) == !(b > a).
- Add the implicit conversion from iterator to const_iterator.
- `#if 0` the broken tests for unimplemented static_ring and dynamic_ring.

Fixes WG21-SG14#75, WG21-SG14#77, WG21-SG14#90, WG21-SG14#93, WG21-SG14#101.
@Quuxplusone Quuxplusone mentioned this issue May 12, 2017
Merged
Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue May 12, 2017
@Quuxplusone
Several cleanups to "ring.h".
5013c6c 
- Add `#pragma once`.
- Add a non-member ADL swap() for rings.
- Fix up the namespace of operator+= and operator-= for ring iterators.
- Fix up (it + n) and (it - n) for ring iterators.
- Add (it - it) for ring iterators.
- Fix a typo in (a >= b) for ring iterators, and make (a <= b) == !(b > a).
- Add the implicit conversion from iterator to const_iterator.
- `#if 0` the broken tests for unimplemented static_ring and dynamic_ring.

Fixes WG21-SG14#75, WG21-SG14#77, WG21-SG14#90, WG21-SG14#93, WG21-SG14#101.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onqtam @carlcook