Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing member difference_type ring_iterator<R,C>::operator-(ring_iterator<R,C>... it) #93

Closed
martinmoene opened this issue May 6, 2017 · 1 comment
Closed

Add missing member difference_type ring_iterator<R,C>::operator-(ring_iterator<R,C>... it) #93

martinmoene opened this issue May 6, 2017 · 1 comment

Comments

@martinmoene
Copy link

No description provided.

@TBBle TBBle mentioned this issue May 7, 2017
Closed
Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue May 12, 2017
@Quuxplusone
Several cleanups to "ring.h".
6929908 
- Add `#pragma once`.
- Add a non-member ADL swap() for rings.
- Fix up the namespace of operator+= and operator-= for ring iterators.
- Fix up (it + n) and (it - n) for ring iterators.
- Add (it - it) for ring iterators.
- Fix a typo in (a >= b) for ring iterators, and make (a <= b) == !(b > a).
- Add the implicit conversion from iterator to const_iterator.
- `#if 0` the broken tests for unimplemented static_ring and dynamic_ring.

Fixes WG21-SG14#77, WG21-SG14#90, WG21-SG14#93, WG21-SG14#101.
Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue May 12, 2017
@Quuxplusone
Several cleanups to "ring.h".
9c76548 
- Add `#pragma once`.
- Add a non-member ADL swap() for rings.
- Fix up the namespace of operator+= and operator-= for ring iterators.
- Fix up (it + n) and (it - n) for ring iterators.
- Add (it - it) for ring iterators.
- Fix a typo in (a >= b) for ring iterators, and make (a <= b) == !(b > a).
- Add the implicit conversion from iterator to const_iterator.
- `#if 0` the broken tests for unimplemented static_ring and dynamic_ring.

Fixes WG21-SG14#77, WG21-SG14#90, WG21-SG14#93, WG21-SG14#101.
Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue May 12, 2017
@Quuxplusone
Several cleanups to "ring.h".
d46b84d 
- Add `#pragma once`.
- Add a non-member ADL swap() for rings.
- Fix up the namespace of operator+= and operator-= for ring iterators.
- Fix up (it + n) and (it - n) for ring iterators.
- Add (it - it) for ring iterators.
- Fix a typo in (a >= b) for ring iterators, and make (a <= b) == !(b > a).
- Add the implicit conversion from iterator to const_iterator.
- `#if 0` the broken tests for unimplemented static_ring and dynamic_ring.

Fixes WG21-SG14#75, WG21-SG14#77, WG21-SG14#90, WG21-SG14#93, WG21-SG14#101.
@Quuxplusone Quuxplusone mentioned this issue May 12, 2017
Merged
Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue May 12, 2017
@Quuxplusone
Several cleanups to "ring.h".
5013c6c 
- Add `#pragma once`.
- Add a non-member ADL swap() for rings.
- Fix up the namespace of operator+= and operator-= for ring iterators.
- Fix up (it + n) and (it - n) for ring iterators.
- Add (it - it) for ring iterators.
- Fix a typo in (a >= b) for ring iterators, and make (a <= b) == !(b > a).
- Add the implicit conversion from iterator to const_iterator.
- `#if 0` the broken tests for unimplemented static_ring and dynamic_ring.

Fixes WG21-SG14#75, WG21-SG14#77, WG21-SG14#90, WG21-SG14#93, WG21-SG14#101.
@Quuxplusone
Copy link
Contributor

Fixed in 5013c6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Quuxplusone @martinmoene