Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner Embed Iframe #2481

Merged
merged 9 commits into from
Dec 21, 2022
Merged

Cleaner Embed Iframe #2481

merged 9 commits into from
Dec 21, 2022

Conversation

foglabs
Copy link
Contributor

@foglabs foglabs commented Oct 3, 2022 •
edited by mrharpo
Loading

Closes #2417

mrharpo
mrharpo approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@mrharpo mrharpo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 👍

demo aapb wgbh-mla org_lite_cpb-aacip_512-w37kp7vq3t (2)

@foglabs foglabs merged commit f66dbdc into master Dec 21, 2022
@foglabs foglabs deleted the clean-ov-iframe branch December 21, 2022 18:40
mrharpo added a commit that referenced this pull request Dec 28, 2022
@mrharpo
Merge branch 'master' into ruby-2.7
4a2c311 
* master:
  Update 6-identity-and-culture.md (#2494)
  Use prettier 404 page for missing catalog pages (#2501)
  Exclude Notes Pages From 'Records in Exhibit' (#2519)
  'add hms times to clip message on share a segment' (#2509)
  🧪 Split CI tests into specs and formatter (#2512)
  ✖️ Remove AMS dependant specs (#2520)
  Cleaner Embed Iframe (#2481)
  'add rows option for snippet solr search' (#2514)
  Fix template names to display titles correct (#2513)
  Fix syntax for new issue templates (#2511)
  Use new Issue template forms (#2510)
  Primary source tweaks (#2507)
  'fix css for featured banner using spritesheet' (#2504)
  'replace busing guid with correct record in prim sets' (#2503)
  Redirects /educator_resources to /primary_source_sets (#2502)
  Remove target for primary source carousel links (#2500)
  Fixes links to primary source sets in homepage carousel (#2499)
  Primary source links (#2498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrharpo mrharpo mrharpo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleaner AAPB Embed option (also relates to OV Redesign)
2 participants
@foglabs @mrharpo