Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'add hms times to clip message on share a segment' #2509

Merged
merged 7 commits into from
Dec 21, 2022
Merged

Conversation

foglabs
Copy link
Contributor

@foglabs foglabs commented Dec 8, 2022

No description provided.

Copy link
Contributor

@mrharpo mrharpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Works on demo 🙌

I added a few basic tests for coverage ✅

@mrharpo mrharpo linked an issue Dec 19, 2022 that may be closed by this pull request
@mrharpo mrharpo merged commit 20a3a6b into master Dec 21, 2022
@mrharpo mrharpo deleted the 24-og-timestamps branch December 21, 2022 22:03
mrharpo added a commit that referenced this pull request Dec 28, 2022
* master:
  Update 6-identity-and-culture.md (#2494)
  Use prettier 404 page for missing catalog pages (#2501)
  Exclude Notes Pages From 'Records in Exhibit' (#2519)
  'add hms times to clip message on share a segment' (#2509)
  🧪 Split CI tests into specs and formatter (#2512)
  ✖️ Remove AMS dependant specs (#2520)
  Cleaner Embed Iframe (#2481)
  'add rows option for snippet solr search' (#2514)
  Fix template names to display titles correct (#2513)
  Fix syntax for new issue templates (#2511)
  Use new Issue template forms (#2510)
  Primary source tweaks (#2507)
  'fix css for featured banner using spritesheet' (#2504)
  'replace busing guid with correct record in prim sets' (#2503)
  Redirects /educator_resources to /primary_source_sets (#2502)
  Remove target for primary source carousel links (#2500)
  Fixes links to primary source sets in homepage carousel (#2499)
  Primary source links (#2498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show original time stamps in Shared Segment
2 participants