Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile production #41

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Dockerfile production #41

merged 3 commits into from
Jun 28, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Jun 24, 2022 •
edited
Loading

Dockerfile: Production

Extends production image

  • COPY all files into container
  • Move WORKDIR to base for use across all images
  • Clean old configs, remove old comments

deploy.sh

  • Adds ENTRYPOINT for deploy
    • Runs server

Fixes broken config from ov_deploy PR3
With ov_deploy PR5
Progresses #40

@mrharpo mrharpo added the bug 🐛 Something isn't working label Jun 24, 2022
@mrharpo mrharpo requested a review from afred June 24, 2022 14:39
@mrharpo mrharpo self-assigned this Jun 24, 2022
@mrharpo mrharpo mentioned this pull request Jun 24, 2022
Merged
afred
afred approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit 7da85de into main Jun 28, 2022
@afred afred deleted the dockerfile-production branch June 28, 2022 22:22
@mrharpo mrharpo added the CD 🏗️ Relating to Continuous Deployment label Jul 5, 2022
@afred afred mentioned this pull request Jul 6, 2022
Closed
4 tasks
@mrharpo mrharpo added this to the v0.1.0 Demo 🏗️ milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
bug 🐛 Something isn't working CD 🏗️ Relating to Continuous Deployment
Projects
No open projects
OV Redesign 2022
Status: ✅ Done
Milestone
v0.1.0 Demo 🏗️
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrharpo @afred