Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename repo from ov_wag -> ov-wag #43

Closed
4 tasks done
mrharpo opened this issue Jul 25, 2022 · 1 comment · Fixed by #44
Closed
4 tasks done

Rename repo from ov_wag -> ov-wag #43

mrharpo opened this issue Jul 25, 2022 · 1 comment · Fixed by #44
Assignees
Labels
breaking 💔 Breaking changes CD 🏗️ Relating to Continuous Deployment documentation 📜 Improvements or additions to documentation maintenance 🔧 Updates and upgrades

Comments

@mrharpo
Copy link
Contributor

mrharpo commented Jul 25, 2022

Because

With ov-deploy #23:
We need to rename this repository from ov_wag to ov-wag because the deploy script expects names to be identical and Rancher does not allow _ in namespaces

Also because standardizing to ov-* will simplify many other issues going forward.

Done when

  • This repo is renamed ov-wag
  • Local git urls are changed across all machines
  • Docker hub repository created for ov-wag
  • New ov-wag Images are pushed to Docker hub
    Links across repositories are amended (optional)
@mrharpo mrharpo added documentation 📜 Improvements or additions to documentation CD 🏗️ Relating to Continuous Deployment maintenance 🔧 Updates and upgrades breaking 💔 Breaking changes labels Jul 25, 2022
@mrharpo mrharpo added this to the v0.2.0 Deploy 🌇 milestone Jul 25, 2022
@mrharpo mrharpo self-assigned this Jul 25, 2022
@mrharpo mrharpo changed the title Rename repo from ov_wag => ov-wag Rename repo from ov_wag -> ov-wag Jul 25, 2022
@mrharpo
Copy link
Contributor Author

mrharpo commented Jul 26, 2022

Exception

The ov_wag python module (i.e. the folder inside the ov-wag python package) is kept as an _ for consistency with python imports.

E.g:

import ov_wag

Also reflected in settings/base.py:

WSGI_APPLICATION = 'ov_wag.wsgi.application'

This is because python interprets - as minus.

Further details: https://pyphilly.org/hyphen-and-underscores-when-use-each-django-and-python/#:~:text=Python%20Prefers%20Underscores,name%20if%20it%20improves%20readability.

@mrharpo mrharpo mentioned this issue Jul 26, 2022
@afred afred closed this as completed in #44 Jul 27, 2022
afred pushed a commit that referenced this issue Jul 27, 2022
* Rename repo from ov_wag to ov-wag. Progresses #43

* Update compose image name for ov-wag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking 💔 Breaking changes CD 🏗️ Relating to Continuous Deployment documentation 📜 Improvements or additions to documentation maintenance 🔧 Updates and upgrades
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant