Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦸 Collections hero_image #112

Merged
merged 17 commits into from
Nov 16, 2023
Merged

🦸 Collections hero_image #112

merged 17 commits into from
Nov 16, 2023

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Nov 14, 2023 •
edited
Loading

Hero image

Adds hero_image and hero_thumb to ov_collections

Closes #99
Coses #107

@mrharpo mrharpo added this to the v0.x.0 Drafts 📝 milestone Nov 14, 2023
@mrharpo mrharpo self-assigned this Nov 14, 2023
@mrharpo mrharpo changed the base branch from main to production November 14, 2023 23:43
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (978a9e8) 92.82% compared to head (0c8235b) 92.92%.

Additional details and impacted files 
@@              Coverage Diff               @@
##           production     #112      +/-   ##
==============================================
+ Coverage       92.82%   92.92%   +0.09%     
==============================================
  Files              42       43       +1     
  Lines             446      452       +6     
==============================================
+ Hits              414      420       +6     
  Misses             32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrharpo mrharpo marked this pull request as ready for review November 14, 2023 23:45
@mrharpo mrharpo requested a review from afred November 14, 2023 23:45
@mrharpo mrharpo added the enhancement ➕ New feature or request label Nov 14, 2023
Base automatically changed from production to main November 16, 2023 15:38
afred
afred approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit 80e4e56 into main Nov 16, 2023
9 checks passed
@afred afred deleted the 99-hero branch November 16, 2023 15:39
mrharpo added a commit that referenced this pull request Nov 16, 2023
@mrharpo
Merge branch 'main' into drafts
e94721f 
* main:
  🦸 Collections `hero_image` (#112)
  🎭 Production image (#101)
mrharpo added a commit that referenced this pull request Nov 17, 2023
@mrharpo
Merge branch 'main' into update-dependencies
d76e404 
* main:
  🦸 Collections `hero_image` (#112)
  🎭 Production image (#101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
enhancement ➕ New feature or request
Projects
OpenVault - Fall 2023
Status: ✅ Done
Milestone
v0.3.0 Drafts 📝
Development

Successfully merging this pull request may close these issues.

Add hero_image to collection model
2 participants
@mrharpo @afred