Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🙈 Hide draft pages #162

Merged
merged 1 commit into from
Feb 20, 2024
Merged

🙈 Hide draft pages #162

merged 1 commit into from
Feb 20, 2024

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Feb 16, 2024

PagesAPIViewSet

Migrates from BaseAPIViewSet to PagesAPIViewSet to hide draft pages from the API response.

Closes #161

@mrharpo mrharpo self-assigned this Feb 16, 2024
@mrharpo mrharpo added bug 🐛 Something isn't working production 🎭 Relating to the production deployment labels Feb 16, 2024
@mrharpo mrharpo added this to the Open Vault Launch milestone Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e240e43) 91.47% compared to head (ee05915) 91.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files          50       50           
  Lines         563      563           
=======================================
  Hits          515      515           
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrharpo mrharpo changed the title Defaults to PagesAPIViewSet 🙈 Hide draft pages Feb 16, 2024
@foglabs foglabs merged commit 0852c81 into main Feb 20, 2024
10 checks passed
@foglabs foglabs deleted the hide-draft-pages branch February 20, 2024 17:23
mrharpo added a commit that referenced this pull request Feb 21, 2024
* main:
  🦶 Footnotes (#156)
  🙈 Hide draft pages (#162)
  👊 Version bump v0.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working production 🎭 Relating to the production deployment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Draft pages should not be included in API results
2 participants