-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🦶 Footnotes #156
🦶 Footnotes #156
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 91.47% 91.87% +0.39%
==========================================
Files 50 54 +4
Lines 563 603 +40
==========================================
+ Hits 515 554 +39
- Misses 48 49 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good to me.. noting that migrations can probably be squashed.
use_json_field=True, | ||
), | ||
), | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can migrations 008, 009, and 010 all be merged into a single migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! We'll squash after demo 🎾
Footnotes
Uses wagtail-footnotes to add footnotes to exhibits body.
Includes
APIField
andSerializer
Closes #155