Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦶 Footnotes #156

Merged
merged 3 commits into from
Feb 21, 2024
Merged

🦶 Footnotes #156

merged 3 commits into from
Feb 21, 2024

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Feb 8, 2024

Footnotes

Uses wagtail-footnotes to add footnotes to exhibits body.

Includes APIField and Serializer

Closes #155

@mrharpo mrharpo added the enhancement ➕ New feature or request label Feb 8, 2024
@mrharpo mrharpo added this to the Open Vault Launch milestone Feb 8, 2024
@mrharpo mrharpo requested a review from foglabs February 8, 2024 00:07
@mrharpo mrharpo self-assigned this Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0852c81) 91.47% compared to head (81a0214) 91.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   91.47%   91.87%   +0.39%     
==========================================
  Files          50       54       +4     
  Lines         563      603      +40     
==========================================
+ Hits          515      554      +39     
- Misses         48       49       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Feb 8, 2024
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me.. noting that migrations can probably be squashed.

use_json_field=True,
),
),
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can migrations 008, 009, and 010 all be merged into a single migration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! We'll squash after demo 🎾

@afred afred merged commit 664ac40 into main Feb 21, 2024
10 checks passed
@afred afred deleted the footnotes branch February 21, 2024 18:01
mrharpo added a commit that referenced this pull request Feb 21, 2024
* main:
  🦶 Footnotes (#156)
  🙈 Hide draft pages (#162)
  👊 Version bump v0.5.0
mrharpo added a commit that referenced this pull request Feb 21, 2024
* main:
  🐩 Wagtail 6 (#159)
  🦶 Footnotes (#156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Footnotes
2 participants