Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthorsOrderable API: include name and image #31

Merged
merged 4 commits into from
Jun 6, 2022
Merged

AuthorsOrderable API: include name and image #31

merged 4 commits into from
Jun 6, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Jun 3, 2022

AuthorsOrderable

  • api_fields now include:
    • name
      • using custom @property def
    • image
      • Because Author inherits from django models.Model
      • Need a custom json serializer
      • ImageSerializedField
        • url
        • title
        • width
        • height

Closes #30

Base automatically changed from 15-ExhibitAPI to main June 6, 2022 16:07
@afred afred force-pushed the 30-AuthorsOrderable-name-image branch from af63400 to 3124d41 Compare June 6, 2022 16:10
@afred afred merged commit 0c1fd0a into main Jun 6, 2022
@afred afred deleted the 30-AuthorsOrderable-name-image branch June 6, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foglabs foglabs foglabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OV Redesign 2022
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AuthorsOrderable api_fields should include name and image
3 participants
@mrharpo @foglabs @afred