Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏰 Base url settings #56

Merged
merged 3 commits into from
Sep 19, 2022
Merged

🏰 Base url settings #56

merged 3 commits into from
Sep 19, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Sep 15, 2022 •
edited
Loading

BASE_URL

Moved url settings from production.py to base.py:

  • OV_BASE_URL
  • OV_ADMIN_BASE_URL

.env

Added documentation for .env values in setup docs:

...
OV_BASE_URL=http://localhost:3000
OV_ADMIN_BASE_URL=http://localhost:8000

@mrharpo mrharpo added the bug 🐛 Something isn't working label Sep 15, 2022
@mrharpo mrharpo added this to the v0.3.0 Collections 🖼️ milestone Sep 15, 2022
@mrharpo mrharpo self-assigned this Sep 15, 2022
@mrharpo mrharpo requested a review from afred September 15, 2022 20:22
@foglabs foglabs merged commit d88f285 into main Sep 19, 2022
@foglabs foglabs deleted the base-url-settings branch September 19, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foglabs foglabs foglabs approved these changes

@afred afred Awaiting requested review from afred

Assignees

@mrharpo mrharpo

Labels
bug 🐛 Something isn't working
Projects
No open projects
OV Redesign 2022
Status: ✅ Done
Milestone
v0.3.0 Collections 🖼️
Development

Successfully merging this pull request may close these issues.
2 participants
@mrharpo @foglabs