Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into mentalist_v0.2 (#26) #27

Merged
merged 2 commits into from
Mar 24, 2018
Merged

Merge master into mentalist_v0.2 (#26) #27

merged 2 commits into from
Mar 24, 2018

Conversation

dfornika
Copy link
Contributor

  • new script to filter Mentalist flag symbols from the calls

  • Add .travis.yml file (Add .travis.yml file #18)

  • Added travis.yml file

  • Added 'Build Status' badge

  • Update .travis.yml

  • Update requirements for TravisCI testing

  • kmer_class_for_locus function no longer exists

  • Don't test on OS X

  • Added coverage badge.

  • Updated macOS install instructions

  • Updated macOS install instructions

  • Update README.md

  • Update runtests.jl

  • TravisCI testing on v0.5 is broken.

  • Added <edam_operation> tag to 'mentalist call' galaxy tool (Added <edam_operation> tag to 'mentalist call' galaxy tool #21)

  • fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases

  • adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly

  • new messages while loading a kmer db, better idea of how much each large step takes

  • lots of new unit tests and a new fastq testing file. Coverage should be much higher now.

  • Change version info for galaxy tools in master branch to 'master'

  • support for analysing multiple samples

  • reorganizing the argparse code and a bit of refactoring

  • adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase

  • small adjustment on a test

  • Fix c_jejuni_fastq_file filename in test

  • Adjusted kmer & vote numbers to match smaller test file.

  • Update conda recipe

  • Don't convert fasta_files paths to absolute paths (Don't convert fasta_files paths to absolute paths #23)

  • Don't convert fasta_files paths to absolute paths

  • Prepend database directory path on to relative paths for allele fasta files in db

  • Don't create db_path variable, check for existence of fasta files

  • Tidy up newlines

  • Added test to check MLST calling after moving a database

  • Relative paths in db (Relative paths in db #25)

  • Don't convert fasta_files paths to absolute paths

  • Prepend database directory path on to relative paths for allele fasta files in db

  • Don't create db_path variable, check for existence of fasta files

  • Tidy up newlines

  • Added test to check MLST calling after moving a database

  • Fixed issue with scheme fasta loading during calling

* new script to filter Mentalist flag symbols from the calls

* Add .travis.yml file (#18)

* Added travis.yml file

* Added 'Build Status' badge

* Update .travis.yml

* Update requirements for TravisCI testing

* kmer_class_for_locus function no longer exists

* Don't test on OS X

* Added coverage badge.

* Updated macOS install instructions

* Updated macOS install instructions

* Update README.md

* Update runtests.jl

* TravisCI testing on v0.5 is broken.

* Added <edam_operation> tag to 'mentalist call' galaxy tool (#21)

* fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases

* adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly

* new messages while loading a kmer db, better idea of how much each large step takes

* lots of new unit tests and a new fastq testing file. Coverage should be much higher now.

* Change version info for galaxy tools in master branch to 'master'

* support for analysing multiple samples

* reorganizing the argparse code and a bit of refactoring

* adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase

* small adjustment on a test

* Fix c_jejuni_fastq_file filename in test

* Adjusted kmer & vote numbers to match smaller test file.

* Update conda recipe

* Don't convert fasta_files paths to absolute paths (#23)

* Don't convert fasta_files paths to absolute paths

* Prepend database directory path on to relative paths for allele fasta files in db

* Don't create db_path variable, check for existence of fasta files

* Tidy up newlines

* Added test to check MLST calling after moving a database

* Relative paths in db (#25)

* Don't convert fasta_files paths to absolute paths

* Prepend database directory path on to relative paths for allele fasta files in db

* Don't create db_path variable, check for existence of fasta files

* Tidy up newlines

* Added test to check MLST calling after moving a database

* Fixed issue with scheme fasta loading during calling
* new script to filter Mentalist flag symbols from the calls

* Add .travis.yml file (#18)

* Added travis.yml file

* Added 'Build Status' badge

* Update .travis.yml

* Update requirements for TravisCI testing

* kmer_class_for_locus function no longer exists

* Don't test on OS X

* Added coverage badge.

* Updated macOS install instructions

* Updated macOS install instructions

* Update README.md

* Update runtests.jl

* TravisCI testing on v0.5 is broken.

* Added <edam_operation> tag to 'mentalist call' galaxy tool (#21)

* fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases

* adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly

* new messages while loading a kmer db, better idea of how much each large step takes

* lots of new unit tests and a new fastq testing file. Coverage should be much higher now.

* Change version info for galaxy tools in master branch to 'master'

* support for analysing multiple samples

* reorganizing the argparse code and a bit of refactoring

* adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase

* small adjustment on a test

* Fix c_jejuni_fastq_file filename in test

* Adjusted kmer & vote numbers to match smaller test file.

* Update conda recipe

* Don't convert fasta_files paths to absolute paths (#23)

* Don't convert fasta_files paths to absolute paths

* Prepend database directory path on to relative paths for allele fasta files in db

* Don't create db_path variable, check for existence of fasta files

* Tidy up newlines

* Added test to check MLST calling after moving a database

* Relative paths in db (#25)

* Don't convert fasta_files paths to absolute paths

* Prepend database directory path on to relative paths for allele fasta files in db

* Don't create db_path variable, check for existence of fasta files

* Tidy up newlines

* Added test to check MLST calling after moving a database

* Fixed issue with scheme fasta loading during calling
@coveralls
Copy link

coveralls commented Mar 24, 2018

Pull Request Test Coverage Report for Build 69

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 70 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 55.317%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/MentaLiST.jl 0 2 0.0%
src/calling_functions.jl 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/MentaLiST.jl 1 0.0%
src/calling_functions.jl 69 61.11%
Totals Coverage Status
Change from base Build 64: 0.0%
Covered Lines: 463
Relevant Lines: 837

💛 - Coveralls

@codecov-io
Copy link

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files           5        5           
  Lines         837      837           
=======================================
  Hits          463      463           
  Misses        374      374
Impacted Files Coverage Δ
src/MentaLiST.jl 0% <0%> (ø) ⬆️
src/calling_functions.jl 61.11% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3140ca2...79b9f36. Read the comment docs.

@dfornika dfornika merged commit 0594e74 into master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants