Don't convert fasta_files paths to absolute paths #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=========================================
- Coverage 55.58% 55.38% -0.2%
=========================================
Files 5 5
Lines 833 836 +3
=========================================
Hits 463 463
- Misses 370 373 +3
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 52
💛 - Coveralls |
dfornika
added a commit
that referenced
this pull request
Mar 24, 2018
* new script to filter Mentalist flag symbols from the calls * Add .travis.yml file (#18) * Added travis.yml file * Added 'Build Status' badge * Update .travis.yml * Update requirements for TravisCI testing * kmer_class_for_locus function no longer exists * Don't test on OS X * Added coverage badge. * Updated macOS install instructions * Updated macOS install instructions * Update README.md * Update runtests.jl * TravisCI testing on v0.5 is broken. * Added <edam_operation> tag to 'mentalist call' galaxy tool (#21) * fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases * adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly * new messages while loading a kmer db, better idea of how much each large step takes * lots of new unit tests and a new fastq testing file. Coverage should be much higher now. * Change version info for galaxy tools in master branch to 'master' * support for analysing multiple samples * reorganizing the argparse code and a bit of refactoring * adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase * small adjustment on a test * Fix c_jejuni_fastq_file filename in test * Adjusted kmer & vote numbers to match smaller test file. * Update conda recipe * Don't convert fasta_files paths to absolute paths (#23) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database
dfornika
added a commit
that referenced
this pull request
Mar 24, 2018
* new script to filter Mentalist flag symbols from the calls * Add .travis.yml file (#18) * Added travis.yml file * Added 'Build Status' badge * Update .travis.yml * Update requirements for TravisCI testing * kmer_class_for_locus function no longer exists * Don't test on OS X * Added coverage badge. * Updated macOS install instructions * Updated macOS install instructions * Update README.md * Update runtests.jl * TravisCI testing on v0.5 is broken. * Added <edam_operation> tag to 'mentalist call' galaxy tool (#21) * fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases * adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly * new messages while loading a kmer db, better idea of how much each large step takes * lots of new unit tests and a new fastq testing file. Coverage should be much higher now. * Change version info for galaxy tools in master branch to 'master' * support for analysing multiple samples * reorganizing the argparse code and a bit of refactoring * adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase * small adjustment on a test * Fix c_jejuni_fastq_file filename in test * Adjusted kmer & vote numbers to match smaller test file. * Update conda recipe * Don't convert fasta_files paths to absolute paths (#23) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Relative paths in db (#25) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Fixed issue with scheme fasta loading during calling
dfornika
added a commit
that referenced
this pull request
Mar 24, 2018
* new script to filter Mentalist flag symbols from the calls * Add .travis.yml file (#18) * Added travis.yml file * Added 'Build Status' badge * Update .travis.yml * Update requirements for TravisCI testing * kmer_class_for_locus function no longer exists * Don't test on OS X * Added coverage badge. * Updated macOS install instructions * Updated macOS install instructions * Update README.md * Update runtests.jl * TravisCI testing on v0.5 is broken. * Added <edam_operation> tag to 'mentalist call' galaxy tool (#21) * fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases * adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly * new messages while loading a kmer db, better idea of how much each large step takes * lots of new unit tests and a new fastq testing file. Coverage should be much higher now. * Change version info for galaxy tools in master branch to 'master' * support for analysing multiple samples * reorganizing the argparse code and a bit of refactoring * adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase * small adjustment on a test * Fix c_jejuni_fastq_file filename in test * Adjusted kmer & vote numbers to match smaller test file. * Update conda recipe * Don't convert fasta_files paths to absolute paths (#23) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Relative paths in db (#25) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Fixed issue with scheme fasta loading during calling
dfornika
added a commit
that referenced
this pull request
Mar 24, 2018
* Merge master into mentalist_v0.2 (#26) * new script to filter Mentalist flag symbols from the calls * Add .travis.yml file (#18) * Added travis.yml file * Added 'Build Status' badge * Update .travis.yml * Update requirements for TravisCI testing * kmer_class_for_locus function no longer exists * Don't test on OS X * Added coverage badge. * Updated macOS install instructions * Updated macOS install instructions * Update README.md * Update runtests.jl * TravisCI testing on v0.5 is broken. * Added <edam_operation> tag to 'mentalist call' galaxy tool (#21) * fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases * adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly * new messages while loading a kmer db, better idea of how much each large step takes * lots of new unit tests and a new fastq testing file. Coverage should be much higher now. * Change version info for galaxy tools in master branch to 'master' * support for analysing multiple samples * reorganizing the argparse code and a bit of refactoring * adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase * small adjustment on a test * Fix c_jejuni_fastq_file filename in test * Adjusted kmer & vote numbers to match smaller test file. * Update conda recipe * Don't convert fasta_files paths to absolute paths (#23) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Relative paths in db (#25) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Fixed issue with scheme fasta loading during calling * Merge master into mentalist_v0.2 (#28) * new script to filter Mentalist flag symbols from the calls * Add .travis.yml file (#18) * Added travis.yml file * Added 'Build Status' badge * Update .travis.yml * Update requirements for TravisCI testing * kmer_class_for_locus function no longer exists * Don't test on OS X * Added coverage badge. * Updated macOS install instructions * Updated macOS install instructions * Update README.md * Update runtests.jl * TravisCI testing on v0.5 is broken. * Added <edam_operation> tag to 'mentalist call' galaxy tool (#21) * fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases * adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly * new messages while loading a kmer db, better idea of how much each large step takes * lots of new unit tests and a new fastq testing file. Coverage should be much higher now. * Change version info for galaxy tools in master branch to 'master' * support for analysing multiple samples * reorganizing the argparse code and a bit of refactoring * adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase * small adjustment on a test * Fix c_jejuni_fastq_file filename in test * Adjusted kmer & vote numbers to match smaller test file. * Update conda recipe * Don't convert fasta_files paths to absolute paths (#23) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Relative paths in db (#25) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Fixed issue with scheme fasta loading during calling
dfornika
added a commit
that referenced
this pull request
Mar 27, 2018
* Merge master into mentalist_v0.2 (#26) * new script to filter Mentalist flag symbols from the calls * Add .travis.yml file (#18) * Added travis.yml file * Added 'Build Status' badge * Update .travis.yml * Update requirements for TravisCI testing * kmer_class_for_locus function no longer exists * Don't test on OS X * Added coverage badge. * Updated macOS install instructions * Updated macOS install instructions * Update README.md * Update runtests.jl * TravisCI testing on v0.5 is broken. * Added <edam_operation> tag to 'mentalist call' galaxy tool (#21) * fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases * adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly * new messages while loading a kmer db, better idea of how much each large step takes * lots of new unit tests and a new fastq testing file. Coverage should be much higher now. * Change version info for galaxy tools in master branch to 'master' * support for analysing multiple samples * reorganizing the argparse code and a bit of refactoring * adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase * small adjustment on a test * Fix c_jejuni_fastq_file filename in test * Adjusted kmer & vote numbers to match smaller test file. * Update conda recipe * Don't convert fasta_files paths to absolute paths (#23) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Relative paths in db (#25) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Fixed issue with scheme fasta loading during calling * Merge master into mentalist_v0.2 (#28) * new script to filter Mentalist flag symbols from the calls * Add .travis.yml file (#18) * Added travis.yml file * Added 'Build Status' badge * Update .travis.yml * Update requirements for TravisCI testing * kmer_class_for_locus function no longer exists * Don't test on OS X * Added coverage badge. * Updated macOS install instructions * Updated macOS install instructions * Update README.md * Update runtests.jl * TravisCI testing on v0.5 is broken. * Added <edam_operation> tag to 'mentalist call' galaxy tool (#21) * fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases * adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly * new messages while loading a kmer db, better idea of how much each large step takes * lots of new unit tests and a new fastq testing file. Coverage should be much higher now. * Change version info for galaxy tools in master branch to 'master' * support for analysing multiple samples * reorganizing the argparse code and a bit of refactoring * adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase * small adjustment on a test * Fix c_jejuni_fastq_file filename in test * Adjusted kmer & vote numbers to match smaller test file. * Update conda recipe * Don't convert fasta_files paths to absolute paths (#23) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Relative paths in db (#25) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Fixed issue with scheme fasta loading during calling * Updated galaxy tool * Removed newline * -s flag not supported * Updated git url in .shed.yml * Fork an unzip process to decompress downloaded cgMLST alleles * Rewrite download_cgmlst_scheme() to handle new zip scheme files from cgmlst.org * Tidy up comments and fix total locus count * Fix test data filenames for L. pneumophila * Add unzip as a conda dependency * variable n_locus not used * Update .shed.yml * Update .shed.yml
dfornika
added a commit
that referenced
this pull request
Jul 26, 2018
* Merge master into mentalist_v0.2 (#26) * new script to filter Mentalist flag symbols from the calls * Add .travis.yml file (#18) * Added travis.yml file * Added 'Build Status' badge * Update .travis.yml * Update requirements for TravisCI testing * kmer_class_for_locus function no longer exists * Don't test on OS X * Added coverage badge. * Updated macOS install instructions * Updated macOS install instructions * Update README.md * Update runtests.jl * TravisCI testing on v0.5 is broken. * Added <edam_operation> tag to 'mentalist call' galaxy tool (#21) * fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases * adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly * new messages while loading a kmer db, better idea of how much each large step takes * lots of new unit tests and a new fastq testing file. Coverage should be much higher now. * Change version info for galaxy tools in master branch to 'master' * support for analysing multiple samples * reorganizing the argparse code and a bit of refactoring * adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase * small adjustment on a test * Fix c_jejuni_fastq_file filename in test * Adjusted kmer & vote numbers to match smaller test file. * Update conda recipe * Don't convert fasta_files paths to absolute paths (#23) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Relative paths in db (#25) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Fixed issue with scheme fasta loading during calling * Merge master into mentalist_v0.2 (#28) * new script to filter Mentalist flag symbols from the calls * Add .travis.yml file (#18) * Added travis.yml file * Added 'Build Status' badge * Update .travis.yml * Update requirements for TravisCI testing * kmer_class_for_locus function no longer exists * Don't test on OS X * Added coverage badge. * Updated macOS install instructions * Updated macOS install instructions * Update README.md * Update runtests.jl * TravisCI testing on v0.5 is broken. * Added <edam_operation> tag to 'mentalist call' galaxy tool (#21) * fixed a bug in the cgmlst download, fasta file decompression could be incorrect in some cases * adding import JSON; was not needed before because some other library was probably loading it, but for the tests we need this explicitly * new messages while loading a kmer db, better idea of how much each large step takes * lots of new unit tests and a new fastq testing file. Coverage should be much higher now. * Change version info for galaxy tools in master branch to 'master' * support for analysing multiple samples * reorganizing the argparse code and a bit of refactoring * adding all multi-sample functionality; better output for novel alleles; parallel downloading for enterobase * small adjustment on a test * Fix c_jejuni_fastq_file filename in test * Adjusted kmer & vote numbers to match smaller test file. * Update conda recipe * Don't convert fasta_files paths to absolute paths (#23) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Relative paths in db (#25) * Don't convert fasta_files paths to absolute paths * Prepend database directory path on to relative paths for allele fasta files in db * Don't create db_path variable, check for existence of fasta files * Tidy up newlines * Added test to check MLST calling after moving a database * Fixed issue with scheme fasta loading during calling * Updated galaxy tool * Removed newline * -s flag not supported * Updated git url in .shed.yml * Fork an unzip process to decompress downloaded cgMLST alleles (#30) * Fork an unzip process to decompress downloaded cgMLST alleles * Rewrite download_cgmlst_scheme() to handle new zip scheme files from cgmlst.org * Tidy up comments and fix total locus count * Fix test data filenames for L. pneumophila * Add unzip as a conda dependency * variable n_locus not used * Change conda version tag * Initial commit for db_info feature * Don't import calling_functions, create own db loading function * Add mentalist_version to db_info report * Use tab-separated output * Use HTTPS for cgmlst.org * Use full organism name in Galaxy Tool Data Table for Enterobase downloads (#61) * Update enterobase scheme download URL (#65) * Update enterobase scheme download URL * bump version number * Remove tests that count votes * Version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22