-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebDriver extension to spec #843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level feedback: can we avoid the "debug" name which conflicts with existing concepts? How about "developer testing mode" or something?
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
Went with "local testing", let me know if you would prefer something else. |
This will allow for simpler testing, by avoiding the significant reporting delays. See also the related WICG/attribution-reporting-api#843
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
This will allow for simpler testing, by avoiding the significant reporting delays. See also the related WICG/attribution-reporting-api#843
By asynchronously recreating the AttributionStorageDelegate with the new value. This will be used as the implementation for forthcoming web driver and test driver commands to allow Attribution Reporting WPTs to run quickly and deterministically by disabling noise and report delays. In the future, we will augment the Storage domain with additional commands and events for interacting with the Attribution Reporting API in order to deprecate and remove the corresponding internals UI. WICG/attribution-reporting-api#843 Bug: 1457165 Change-Id: I69f4620b4c389fe72d621942654073c491f230a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4632317 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/main@{#1162911}
This will allow for simpler testing, by avoiding the significant reporting delays. See also the related WICG/attribution-reporting-api#843
This will allow for simpler testing, by avoiding the significant reporting delays. See also the related WICG/attribution-reporting-api#843
This will allow for simpler testing, by avoiding the significant reporting delays. See also the related WICG/attribution-reporting-api#843
Preview | Diff