Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebDriver extension to spec #843

Merged
merged 10 commits into from
Jun 27, 2023
Merged

Add WebDriver extension to spec #843

merged 10 commits into from
Jun 27, 2023

Conversation

johnivdel
Copy link
Collaborator

@johnivdel johnivdel commented Jun 8, 2023

@johnivdel johnivdel requested a review from apasel422 June 12, 2023 16:03
Copy link
Collaborator

@csharrison csharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level feedback: can we avoid the "debug" name which conflicts with existing concepts? How about "developer testing mode" or something?

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
johnivdel and others added 2 commits June 13, 2023 13:36
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
@johnivdel
Copy link
Collaborator Author

High level feedback: can we avoid the "debug" name which conflicts with existing concepts? How about "developer testing mode" or something?

Went with "local testing", let me know if you would prefer something else.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
alexmturner added a commit to patcg-individual-drafts/private-aggregation-api that referenced this pull request Jun 14, 2023
This will allow for simpler testing, by avoiding the significant
reporting delays. See also the related
WICG/attribution-reporting-api#843
johnivdel and others added 3 commits June 15, 2023 12:39
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
alexmturner added a commit to patcg-individual-drafts/private-aggregation-api that referenced this pull request Jun 21, 2023
This will allow for simpler testing, by avoiding the significant
reporting delays. See also the related
WICG/attribution-reporting-api#843
aarongable pushed a commit to chromium/chromium that referenced this pull request Jun 27, 2023
By asynchronously recreating the AttributionStorageDelegate with the
new value.

This will be used as the implementation for forthcoming web driver and
test driver commands to allow Attribution Reporting WPTs to run quickly
and deterministically by disabling noise and report delays.

In the future, we will augment the Storage domain with additional
commands and events for interacting with the Attribution Reporting API
in order to deprecate and remove the corresponding internals UI.

WICG/attribution-reporting-api#843

Bug: 1457165
Change-Id: I69f4620b4c389fe72d621942654073c491f230a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4632317
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1162911}
@johnivdel johnivdel merged commit a6bc230 into main Jun 27, 2023
2 checks passed
alexmturner added a commit to patcg-individual-drafts/private-aggregation-api that referenced this pull request Jun 28, 2023
This will allow for simpler testing, by avoiding the significant
reporting delays. See also the related
WICG/attribution-reporting-api#843
alexmturner added a commit to patcg-individual-drafts/private-aggregation-api that referenced this pull request Jul 10, 2023
This will allow for simpler testing, by avoiding the significant
reporting delays. See also the related
WICG/attribution-reporting-api#843
alexmturner added a commit to patcg-individual-drafts/private-aggregation-api that referenced this pull request Jul 10, 2023
This will allow for simpler testing, by avoiding the significant
reporting delays. See also the related
WICG/attribution-reporting-api#843
@apasel422 apasel422 deleted the ua-automation branch August 3, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants