Spec: Add WebDriver extension #64
Conversation
|
@linnan-github, could you PTAL? Thanks! |
spec.bs
Outdated
| @@ -352,6 +356,9 @@ A user agent holds a <dfn>contribution cache</dfn>, which is a [=list=] of | |||
| A user agent holds a <dfn>debug scope map</dfn>, which is an [=ordered map=] | |||
| from [=debug scopes=] to [=debug details=]. | |||
|
|
|||
| A user agent holds a <dfn>developer mode enabled</dfn>, which is a [=boolean=], | |||
There was a problem hiding this comment.
Shall we align with ARA and use "The user-agent holds an associated boolean automation local testing mode (default false)."
There was a problem hiding this comment.
I removed associated to align with the other storage language, but moved it to the user-agent automation section to align with ARA
|
@mathiasbynens, could you PTAL? Rick Byers suggested you as a reviewer. Thanks! |
spec.bs
Outdated
|
|
||
| The [=remote end steps=] are: | ||
|
|
||
| 1. If |parameters| is not a JSON [[ECMASCRIPT#sec-json-object|Object]], return a |
There was a problem hiding this comment.
The section of the ECMAScript spec this points to is about the JSON object, i.e. globalThis.JSON, but that’s not what we’re interested in here. To fix this, link to https://tc39.es/ecma262/#sec-objects instead of #sec-json-object. (We could also change the phrasing to “is not an Object” or “is not a JSON-formatted object” to be more precise but that’s not a blocker.)
Relevant precedent in the WebDriver classic spec is e.g. here: https://w3c.github.io/webdriver/#add-cookie
There was a problem hiding this comment.
Ah good point! Fixed the link and updated the phrasing
This will allow for simpler testing, by avoiding the significant reporting delays. See also the related WICG/attribution-reporting-api#843
|
Thanks for the review! |
SHA: 3717d8a Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fixes a link and clarifies the prose slightly. See patcg-individual-drafts/private-aggregation-api#64 (comment) for explanation.
Fixes a link and clarifies the prose slightly. See patcg-individual-drafts/private-aggregation-api#64 (comment) for explanation.
This will allow for simpler testing, by avoiding the significant reporting delays. See also the related
WICG/attribution-reporting-api#843
Preview | Diff