Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is Delegate-CH a pragma or not? #159

Closed
eeeps opened this issue May 17, 2024 · 1 comment · Fixed by #160
Closed

Is Delegate-CH a pragma or not? #159

eeeps opened this issue May 17, 2024 · 1 comment · Fixed by #160

Comments

@eeeps
Copy link
Collaborator

eeeps commented May 17, 2024

Chrome currently only supports:

<meta http-equiv="Delegate-CH">

but if I'm reading the spec correctly (step three of the Delegate-CH algorithm), it seems to call for:

<meta name="Delegate-CH">

Which is correct?
arichiv added a commit that referenced this issue May 21, 2024
@arichiv
Use http-equiv not name for Delegate-CH
4fd70cb 
fixes #159
@arichiv arichiv mentioned this issue May 21, 2024
Merged
@miketaylr
Copy link
Collaborator

Thanks for the issue @eeeps :)

I think given @arichiv's PR, we can conclude that http-equiv is the right answer.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 21, 2024
@progers @chromium-wpt-export-bot
Revert "Update enablement approach for sec-ch-width tests"
b061adf 
This reverts commit 0cc26e2b517e84e599540c2f13260726c7c6c159.

Reason for revert: Spec was updated to use http-equiv after all:
WICG/client-hints-infrastructure#159

Original change's description:
> Update enablement approach for sec-ch-width tests
>
> There are some higher-level interop/spec issues with how to enable
> sec-ch-width. This patch switches the tests to use name="Delegate-CH",
> which is per-spec [1], as well as sending the Accept-CH header.
>
> [1] https://wicg.github.io/client-hints-infrastructure/#delegate-ch-algo
>
> Bug: 335630145
> Change-Id: Id37303bce2fb73c85505262cc5543e23701bd091
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548997
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Traian Captan <tcaptan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1303438}

Bug: 335630145
Change-Id: I890fc0dc9faa1d6fa8140ba56199c18fb687f36e
Merged
aarongable pushed a commit to chromium/chromium that referenced this issue May 21, 2024
@progers
Revert "Update enablement approach for sec-ch-width tests"
43ac43f 
This reverts commit 0cc26e2.

Reason for revert: Spec was updated to use http-equiv after all:
WICG/client-hints-infrastructure#159

Original change's description:
> Update enablement approach for sec-ch-width tests
>
> There are some higher-level interop/spec issues with how to enable
> sec-ch-width. This patch switches the tests to use name="Delegate-CH",
> which is per-spec [1], as well as sending the Accept-CH header.
>
> [1] https://wicg.github.io/client-hints-infrastructure/#delegate-ch-algo
>
> Bug: 335630145
> Change-Id: Id37303bce2fb73c85505262cc5543e23701bd091
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548997
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Traian Captan <tcaptan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1303438}

Bug: 335630145
Change-Id: I890fc0dc9faa1d6fa8140ba56199c18fb687f36e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5555162
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304037}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 21, 2024
@progers @chromium-wpt-export-bot
Revert "Update enablement approach for sec-ch-width tests"
8394274 
This reverts commit 0cc26e2b517e84e599540c2f13260726c7c6c159.

Reason for revert: Spec was updated to use http-equiv after all:
WICG/client-hints-infrastructure#159

Original change's description:
> Update enablement approach for sec-ch-width tests
>
> There are some higher-level interop/spec issues with how to enable
> sec-ch-width. This patch switches the tests to use name="Delegate-CH",
> which is per-spec [1], as well as sending the Accept-CH header.
>
> [1] https://wicg.github.io/client-hints-infrastructure/#delegate-ch-algo
>
> Bug: 335630145
> Change-Id: Id37303bce2fb73c85505262cc5543e23701bd091
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548997
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Traian Captan <tcaptan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1303438}

Bug: 335630145
Change-Id: I890fc0dc9faa1d6fa8140ba56199c18fb687f36e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5555162
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304037}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 21, 2024
@progers @chromium-wpt-export-bot
Revert "Update enablement approach for sec-ch-width tests"
9036de5 
This reverts commit 0cc26e2b517e84e599540c2f13260726c7c6c159.

Reason for revert: Spec was updated to use http-equiv after all:
WICG/client-hints-infrastructure#159

Original change's description:
> Update enablement approach for sec-ch-width tests
>
> There are some higher-level interop/spec issues with how to enable
> sec-ch-width. This patch switches the tests to use name="Delegate-CH",
> which is per-spec [1], as well as sending the Accept-CH header.
>
> [1] https://wicg.github.io/client-hints-infrastructure/#delegate-ch-algo
>
> Bug: 335630145
> Change-Id: Id37303bce2fb73c85505262cc5543e23701bd091
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548997
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Traian Captan <tcaptan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1303438}

Bug: 335630145
Change-Id: I890fc0dc9faa1d6fa8140ba56199c18fb687f36e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5555162
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304037}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 30, 2024
@progers @moz-wptsync-bot
Bug 1898003 [wpt PR 46405] - Revert "Update enablement approach for s…
b2f76c8 
…ec-ch-width tests", a=testonly

Automatic update from web-platform-tests
Revert "Update enablement approach for sec-ch-width tests"

This reverts commit 0cc26e2b517e84e599540c2f13260726c7c6c159.

Reason for revert: Spec was updated to use http-equiv after all:
WICG/client-hints-infrastructure#159

Original change's description:
> Update enablement approach for sec-ch-width tests
>
> There are some higher-level interop/spec issues with how to enable
> sec-ch-width. This patch switches the tests to use name="Delegate-CH",
> which is per-spec [1], as well as sending the Accept-CH header.
>
> [1] https://wicg.github.io/client-hints-infrastructure/#delegate-ch-algo
>
> Bug: 335630145
> Change-Id: Id37303bce2fb73c85505262cc5543e23701bd091
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548997
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Traian Captan <tcaptan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1303438}

Bug: 335630145
Change-Id: I890fc0dc9faa1d6fa8140ba56199c18fb687f36e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5555162
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304037}

--

wpt-commits: 9036de52d5ef50db887553fd4602955cb7ca269d
wpt-pr: 46405
jamienicol pushed a commit to jamienicol/gecko that referenced this issue May 31, 2024
@progers @moz-wptsync-bot
Bug 1898003 [wpt PR 46405] - Revert "Update enablement approach for s…
cc23cda 
…ec-ch-width tests", a=testonly

Automatic update from web-platform-tests
Revert "Update enablement approach for sec-ch-width tests"

This reverts commit 0cc26e2b517e84e599540c2f13260726c7c6c159.

Reason for revert: Spec was updated to use http-equiv after all:
WICG/client-hints-infrastructure#159

Original change's description:
> Update enablement approach for sec-ch-width tests
>
> There are some higher-level interop/spec issues with how to enable
> sec-ch-width. This patch switches the tests to use name="Delegate-CH",
> which is per-spec [1], as well as sending the Accept-CH header.
>
> [1] https://wicg.github.io/client-hints-infrastructure/#delegate-ch-algo
>
> Bug: 335630145
> Change-Id: Id37303bce2fb73c85505262cc5543e23701bd091
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548997
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Traian Captan <tcaptan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1303438}

Bug: 335630145
Change-Id: I890fc0dc9faa1d6fa8140ba56199c18fb687f36e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5555162
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304037}

--

wpt-commits: 9036de52d5ef50db887553fd4602955cb7ca269d
wpt-pr: 46405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use http-equiv not name for Delegate-CH WICG/client-hints-infrastructure
2 participants
@miketaylr @eeeps