Propagate user activation to the opener window #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 9, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows. This feature is behind a disabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 30, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind a disabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 3, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind a disabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
This was referenced May 6, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 9, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind a disabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 9, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 10, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 15, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 15, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 15, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 15, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 17, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 21, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 22, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 22, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393891 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1304599}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 22, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393891 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1304599}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 22, 2024
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393891 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1304599}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 30, 2024
…user activation to the opener, a=testonly Automatic update from web-platform-tests [document picture-in-picture] Propagate user activation to the opener This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393891 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1304599} -- wpt-commits: 58221c60ed5e96327514caffba41f9ad583b20b0 wpt-pr: 45621
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
May 31, 2024
…user activation to the opener, a=testonly Automatic update from web-platform-tests [document picture-in-picture] Propagate user activation to the opener This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393891 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1304599} -- wpt-commits: 58221c60ed5e96327514caffba41f9ad583b20b0 wpt-pr: 45621
|
With https://chromestatus.com/feature/5185710702460928 shipping in Chrome 127, it would be nice to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes user activations in the document picture-in-picture window usable inside the opener window. This makes it more ergonomic to use user-activation-gated APIs, since often event handlers in the document PiP window are actually run in the opener's context, so the opener's context needs access to the user gesture.