This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Restore persistent-usage-record and update editors #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update editors to add w3cid
encrypted-media-respec.html
Outdated
| @@ -1463,6 +1468,48 @@ <h2><dfn>MediaKeys</dfn> Interface</h2> | |||
| See <a def-id="session-storage"></a>. | |||
| </p> | |||
| </td></tr> | |||
| <tr><td><dfn><code id="idl-def-MediaKeySessionType.persistent-usage-record">persistent-usage-record</code></dfn></td><td> | |||
There was a problem hiding this comment.
Nit, should be:
<code><dfn>persistent-usage-record</dfn></code>Wrapping in code allows ReSpec to automatically put code around any:
<a>persistent-usage-record</a>Also, it's probably not a good idea to try to recreate ReSpec's generated ids, as they can change.
Same applies for the rest.
There was a problem hiding this comment.
Good catch, thanks.
I guess the ReSpec ids are there because at one point something wasn't working without them. I'd prefer to remove them as a separate step, since they are there throughout the spec right now. It should probably be done in the upstream repo also.
|
Does anyone have further comments on this PR ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff