Spec partition nonce functionality #149
Conversation
| boolean |isCredentialless| and [=fenced frame config instance/partition nonce=] or null | ||
| |newFencedFrameNonce|: | ||
|
|
||
| 1. If |credentialless| is true, return |this|'s [=top-level browsing context=]'s |
There was a problem hiding this comment.
credentialless => isCredentialless
There was a problem hiding this comment.
I can't really change this, since it corresponds to an exposed IDL attribute.
https://wicg.github.io/anonymous-iframe/#spec-window-attribute
There was a problem hiding this comment.
Well where are you getting |credentialless| from then? It's not just a global variable is it?
There was a problem hiding this comment.
It's a local variable, but I meant it would be weird to call it something else when it corresponds exactly to this preexisting field, and the same name is used throughout the Iframe credentialless spec
There was a problem hiding this comment.
Where is this local variable defined? Sorry I don't think I'm getting it.
There was a problem hiding this comment.
Oh, I misread this. I didn't mean to name the variable isCredentialless above in the declaration. The iframe credentialless spec refers to this kind of variable as credentialless throughout, so it would be inconsistent naming to use isCredentialless here. Changed the declaration back to credentialless to match.
| boolean |isCredentialless| and [=fenced frame config instance/partition nonce=] or null | ||
| |newFencedFrameNonce|: | ||
|
|
||
| 1. If |credentialless| is true, return |this|'s [=top-level browsing context=]'s |
There was a problem hiding this comment.
Well where are you getting |credentialless| from then? It's not just a global variable is it?
|
@domfarolino I think all the comments are addressed now |
Preview | Diff