Clarify Floc Eligibility

[shigeki]

I found that the following comments at FlocEligibilityObserver in chrome/browser/federated_learning/floc_eligibility_observer.h.

// computation. The history entry is eligible for floc computation if all of the
// following conditions hold:
// 1) the IP of the navigation was publicly routable.
// 2) the interest-cohort permissions policy in the main document allows the
// floc history inclusion.
// 3) either the page has an ad resource, or the document.interestCohort API is
// used in the page.

Only 2) and the first half of 3) are described in the article of the web.dev but not others.

If 1 is applied during trials, please add notes about it.
It is beneficial for users to know their internal pages are out of FLoC.

I have one question regarding 1.
The IP of the navigation seems to be derived from a socket, not a DNS record.
Are pages eligible for FLoC computation even when clients are connecting via an internal proxy to external servers?

[jkarlin]

Good point. @samdutton can you add the fact that pages served from private IP addresses (e.g., intranet pages) won't be part of the floc computation to the web.dev article please?

I believe that is correct (though I have not manually verified) that pages loaded from a proxy on a private address would not be included.

[samdutton]

@samdutton can you add the fact that pages served from private IP addresses (e.g., intranet pages) won't be part of the floc computation to the web.dev article please?

Sure -- will do.

…

On Thu, 1 Apr 2021 at 19:38, Josh Karlin ***@***.***> wrote: Good point. @samdutton <https://github.com/samdutton> can you add the fact that pages served from private IP addresses (e.g., intranet pages) won't be part of the floc computation to the web.dev article please? I believe that is correct (though I have not manually verified) that pages loaded from a proxy on a private address would not be included. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#85 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABSDKRWW7BCXRND5HWYUPDTGS4RVANCNFSM42GJUPNQ> .

[simonft]

It might be worth calling out the second half of 3 ("... or the document.interestCohort API is used in the page") in the article as well. I've already seen someone confused when seeing a change in the cohort returned by document.interestCohort API in the browser console on a page that wouldn't otherwise update the cohort.

[samdutton]

Thanks @shigeki and @simonft — I've done PRs with updates based on your suggestions.

[shigeki]

@samdutton Thanks. The documents were updates as expected.