Add File Handling manifest member, parsing, LaunchQueue/LaunchParams #51
Conversation
| Execute a file handler launch | ||
| </h2> | ||
| <p> | ||
| The steps to <dfn>execute a file handler launch</dfn> are given by |
There was a problem hiding this comment.
@inexorabletash should this wording also be modernized, like in w3c/compute-pressure#96
There was a problem hiding this comment.
Maybe not? As this isn't actually a web-facing method, i.e. there's no webidl definition for it or its parameters.
| <ol> | ||
| <li>[=list/for each=] |extension:string| of |extensions| | ||
| <ol> | ||
| <li>If |filename| does not end in |extension|, |
There was a problem hiding this comment.
Maybe we should do trimming of filenames? We used to do trimming in web app manifest, so might be good to check what we do there.
There was a problem hiding this comment.
@annevk I see that infra has https://infra.spec.whatwg.org/#string-starts-with so we need something for suffix/ends with?
There was a problem hiding this comment.
Do you mean whitespace trimming? The file names are provided by the OS as command line arguments. AFAIK there's no rule saying a file name can't start with a space.
index.html
Outdated
| <li>Else, set |launches|[|file_handler|] to a list | ||
| with the single element |filename|. | ||
| </li> | ||
| <li>Continue to next element of |files|. |
There was a problem hiding this comment.
[=iteration/continue=]
Not sure what is the correct wording here @annevk?
|
PTAL @dmurph |
| </section> | ||
| <section> | ||
| <h3> | ||
| Handling Web App Launches |
There was a problem hiding this comment.
I wonder if we need to acknowledge the step of 'creating a new document' or browsing context.
"user agent SHOULD navigate to url and the appropriate browsing context is set to a new top level browsing context." (same line as in protocol handling) somewhere in the algorithm?
Should we be mentioning edge cases like redirection? Or are we not mentioning that on purpose?
There was a problem hiding this comment.
I've added a line about the creation of the new browser context. I didn't use the exact same language since it's a step in an algorithm rather than part of a paragraph.
Redirection (and reload) should be mentioned but I think that's sort of out of the scope of file handling. It should definitely be mentioned when the LaunchQueue/Params spec is fleshed out.
| </section> | ||
| <section> | ||
| <h3> | ||
| Handling Web App Launches |
|
thanks! |
Add description of manifest member file_handlers as well as a rough sketch of LaunchQueue and LaunchParams.
Preview | Diff