Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "Observer" to "SubscriptionObserver" #101

Merged

Conversation

keithamus
Copy link
Collaborator

@keithamus keithamus commented Jan 10, 2024

Closes #99


Preview | Diff

@domfarolino
Copy link
Collaborator

The IPR bot is upset, so you could you follow the instructions on https://labs.w3.org/repo-manager/pr/id/WICG/observable/101, and join the WICG so the bot will be happy with this and your future contributions?

spec.bs Outdated Show resolved Hide resolved
@keithamus
Copy link
Collaborator Author

@domfarolino all green now 🙌

spec.bs Outdated Show resolved Hide resolved
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
@domfarolino domfarolino merged commit 3eff602 into WICG:master Jan 18, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jan 18, 2024
SHA: 3eff602
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@keithamus keithamus deleted the rename-observer-to-subscriptionobserver branch January 18, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are IDL names like Observer too ambiguous?
2 participants